Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bank account details for employee#430

Merged
supriya3105 merged 14 commits intodevelopfrom
bank-account-details-for-employee
Jun 13, 2022
Merged

Bank account details for employee#430
supriya3105 merged 14 commits intodevelopfrom
bank-account-details-for-employee

Conversation

@sudeeptarlekar
Copy link
Contributor

@sudeeptarlekar sudeeptarlekar commented Jun 1, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Front-end-Back-end-Bank-account-details-page-for-employees-e1a961ee6e9f4c13b2437742ffedd678

Summary

Added ability to all users to add bank details.

Preview

bank.detail.mp4

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tested on sandbox account

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code

@pr-triage pr-triage bot added the PR: draft label Jun 1, 2022
@sudeeptarlekar sudeeptarlekar force-pushed the bank-account-details-for-employee branch from ff72826 to 05bcc18 Compare June 1, 2022 09:31
rohitjoshixyz
rohitjoshixyz reviewed Jun 2, 2022
View reviewed changes
rohitjoshixyz
rohitjoshixyz reviewed Jun 2, 2022
View reviewed changes
@sudeeptarlekar sudeeptarlekar force-pushed the bank-account-details-for-employee branch 3 times, most recently from 9f2a2cc to 9766922 Compare June 9, 2022 11:02
@sudeeptarlekar sudeeptarlekar marked this pull request as ready for review June 9, 2022 11:11
@sudeeptarlekar sudeeptarlekar marked this pull request as draft June 9, 2022 11:12
@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

89.12 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/users/invitations_controller.rb 86.36 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@sudeeptarlekar sudeeptarlekar force-pushed the bank-account-details-for-employee branch from 87d6ad5 to e9f83dc Compare June 9, 2022 15:45
@sudeeptarlekar sudeeptarlekar marked this pull request as ready for review June 9, 2022 15:45
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 10, 2022

@apoorv1316 Please test this PR today .

rohitjoshixyz
rohitjoshixyz approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Great Job!

app/models/wise_account.rb
belongs_to :user
belongs_to :company

validates :user_id, uniqueness: { scope: :company_id }
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good

@rohitjoshixyz
Copy link
Contributor

rohitjoshixyz commented Jun 13, 2022

@sudeeptarlekar Humble request to send smaller PRs going forward. 😄

apoorv-mishra
apoorv-mishra approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 13, 2022

@sudeeptarlekar Overall the functionality looks good. Just one confirmation for the tab name. In the video you have added to the PR, the tab name is Billing. Expected name if Bank Account Details.

@sudeeptarlekar
Added functionality for bank details
a0eccab 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added specs
c74c668 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Fixed loader and eslint issues
63e14d8 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Refactored code
78219d6 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added specs for wise controller
ce56784 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added specs for recipients controller
79e6fa5 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added spec for policy
67ffbd1 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Updated cassettes with production data
73386e2 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added more specs
e528356 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Updated env example file
d304dc9 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added VCR of production API for delete recipient
216ce16 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Updated ENV sample
b05ffe2 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Handled multiple API calls from index page
00207cb 
Signed-off-by: sudeeptarlekar <[email protected]>
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 13, 2022

@sudeeptarlekar Please resolve the conflicts and CI checks that are failing

@sudeeptarlekar sudeeptarlekar force-pushed the bank-account-details-for-employee branch from a8ba76c to 759def3 Compare June 13, 2022 11:50
@sudeeptarlekar
Copy link
Contributor Author

sudeeptarlekar commented Jun 13, 2022

Fixed
bank_account_details

@sudeeptarlekar sudeeptarlekar force-pushed the bank-account-details-for-employee branch from 759def3 to a9659c7 Compare June 13, 2022 12:23
@sudeeptarlekar sudeeptarlekar force-pushed the bank-account-details-for-employee branch from a9659c7 to 4264c4a Compare June 13, 2022 15:00
@supriya3105 supriya3105 merged commit 185532e into develop Jun 13, 2022
@supriya3105 supriya3105 deleted the bank-account-details-for-employee branch June 13, 2022 18:03
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@sudeeptarlekar
Bank account details for employee (#430)
0e7aad6 
* Added functionality for bank details

Signed-off-by: sudeeptarlekar <[email protected]>

* Added specs

Signed-off-by: sudeeptarlekar <[email protected]>

* Fixed loader and eslint issues

Signed-off-by: sudeeptarlekar <[email protected]>

* Refactored code

Signed-off-by: sudeeptarlekar <[email protected]>

* Added specs for wise controller

Signed-off-by: sudeeptarlekar <[email protected]>

* Added specs for recipients controller

Signed-off-by: sudeeptarlekar <[email protected]>

* Added spec for policy

Signed-off-by: sudeeptarlekar <[email protected]>

* Updated cassettes with production data

Signed-off-by: sudeeptarlekar <[email protected]>

* Added more specs

Signed-off-by: sudeeptarlekar <[email protected]>

* Updated env example file

Signed-off-by: sudeeptarlekar <[email protected]>

* Added VCR of production API for delete recipient

Signed-off-by: sudeeptarlekar <[email protected]>

* Updated ENV sample

Signed-off-by: sudeeptarlekar <[email protected]>

* Handled multiple API calls from index page

Signed-off-by: sudeeptarlekar <[email protected]>

* Change from billing to bank account details

Signed-off-by: sudeeptarlekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keshavbiswa keshavbiswa keshavbiswa left review comments

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@supriya3105 supriya3105 Awaiting requested review from supriya3105

+2 more reviewers

@apoorv-mishra apoorv-mishra apoorv-mishra approved these changes

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sudeeptarlekar @supriya3105 @rohitjoshixyz @apoorv-mishra @apoorv1316 @keshavbiswa