Fixed the weekly time entry view after week change#432
Merged
Conversation
Signed-off-by: sudeeptarlekar <[email protected]>
Current Code Coverage Percent of this PR:84.24 %Files having coverage below 100%
|
Contributor
|
@abinashpa Please review this code. |
abinashpa
reviewed
Jun 2, 2022
Contributor
|
@sudeeptarlekar The app shows total hours for the week correctly but something is wrong with rendering entries. |
Contributor
Author
|
Because we are not updating current entries and week view used current entries to display hours. |
Contributor
|
@sudeeptarlekar The total hours of currentEntries are for that particular row. Total hours for the entire week are calculated by calculateTotalWeeklyDuration. |
Contributor
|
@abinashpa @sudeeptarlekar Please discuss the changes and close the comments here . I could not understand from the review comments if something needs to be fixed or not. |
apoorv1316
approved these changes
Jun 2, 2022
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
Fixed the weekly time entry view after week change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sudeeptarlekar [email protected]
Notion card
Summary
When we change the week in weekly view, time entries are not getting updated correctly. Fixed the issue.
Type of change
How Has This Been Tested?
Expected: Time entries should update according to week.
Checklist: