Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor specs#435

Merged
supriya3105 merged 8 commits intodevelopfrom
refactor-specs
Jun 3, 2022
Merged

Refactor specs#435
supriya3105 merged 8 commits intodevelopfrom
refactor-specs

Conversation

@sudeeptarlekar
Copy link
Contributor

Notion card

NA

Summary

Fixed and refactored specs

Signed-off-by: sudeeptarlekar <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Current Code Coverage Percent of this PR:

86.9 %

Files having coverage below 100%

Impacted Files Coverage
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.88 %
/lib/benchmarking/benchmarker.rb 0.0 %

Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: sudeeptarlekar <[email protected]>
Signed-off-by: sudeeptarlekar <[email protected]>
Signed-off-by: sudeeptarlekar <[email protected]>
@supriya3105 supriya3105 merged commit 8077d68 into develop Jun 3, 2022
@supriya3105 supriya3105 deleted the refactor-specs branch June 3, 2022 08:30
@pr-triage pr-triage bot added the PR: merged label Jun 3, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
* Refactored timezones controller and specs

Signed-off-by: sudeeptarlekar <[email protected]>

* Added specs for subscription controller

Signed-off-by: sudeeptarlekar <[email protected]>

* Fixed the description

Signed-off-by: sudeeptarlekar <[email protected]>

* Added specs for invoice payments controller

Signed-off-by: sudeeptarlekar <[email protected]>

* Refactored client policy specs

Signed-off-by: sudeeptarlekar <[email protected]>

* Refactored specs

Signed-off-by: sudeeptarlekar <[email protected]>

* Removed specs

Signed-off-by: sudeeptarlekar <[email protected]>

* Refactored invoices controller

Signed-off-by: sudeeptarlekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants