Thanks to visit codestin.com
Credit goes to github.com

Skip to content

project add edit fix#436

Merged
ajinkyaa merged 1 commit intodevelopfrom
bugfix/project-add-edit-fix
Jun 6, 2022
Merged

project add edit fix#436
ajinkyaa merged 1 commit intodevelopfrom
bugfix/project-add-edit-fix

Conversation

@ajinkyaa
Copy link
Contributor

@ajinkyaa ajinkyaa commented Jun 2, 2022

Project Modal Bugfix.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Current Code Coverage Percent of this PR:

84.24 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/timezone_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.88 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

@supriya3105 supriya3105 requested a review from apoorv1316 June 2, 2022 10:53
@supriya3105
Copy link
Contributor

@apoorv1316 Please test

@apoorv1316
Copy link
Collaborator

@ajinkyaa Please add a loom video and notion card. I don't know what this pr is supposed to fix.

@ajinkyaa
Copy link
Contributor Author

ajinkyaa commented Jun 3, 2022

@apoorv1316 @supriya3105 Previously, Project modals were not showing on click of edit and new button.
Now after the fix it started to show up.
I have attached the screenshot of the modals.

Screenshot 2022-06-03 at 6 05 16 PM

Screenshot 2022-06-03 at 6 05 07 PM

@ajinkyaa ajinkyaa merged commit d76f2cb into develop Jun 6, 2022
@ajinkyaa ajinkyaa deleted the bugfix/project-add-edit-fix branch June 6, 2022 05:16
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants