Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove payment options list from view invoice page#437

Merged
supriya3105 merged 1 commit intodevelopfrom
remove-payment-options
Jun 2, 2022
Merged

Remove payment options list from view invoice page#437
supriya3105 merged 1 commit intodevelopfrom
remove-payment-options

Conversation

@apoorv-mishra
Copy link
Contributor

@apoorv-mishra apoorv-mishra commented Jun 2, 2022

Notion card

NA

Summary

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@apoorv-mishra apoorv-mishra requested a review from apoorv1316 June 2, 2022 13:16
@apoorv-mishra apoorv-mishra changed the title Remove payment options from view invoice page Remove payment options list from view invoice page Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Current Code Coverage Percent of this PR:

84.55 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 57.14 %
/app/models/invoice.rb 96.3 %
/app/policies/client_policy.rb 95.45 %
/app/policies/invoice_policy.rb 94.12 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/timezone_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.88 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/app/controllers/internal_api/v1/clients_controller.rb 94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb 94.87 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 95.45 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

@supriya3105 supriya3105 merged commit a7addd4 into develop Jun 2, 2022
@supriya3105 supriya3105 deleted the remove-payment-options branch June 2, 2022 14:42
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Get rid of payment menu since only one payment option is implemented …
3fde5cb 
…so far (#437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

1 more reviewer

@supriya3105 supriya3105 supriya3105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apoorv-mishra @supriya3105