Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUG]Disallow connected param in create/update reqs for payments providers#440

Merged
supriya3105 merged 1 commit intodevelopfrom
fix-invoice-settings
Jun 3, 2022
Merged

[BUG]Disallow connected param in create/update reqs for payments providers#440
supriya3105 merged 1 commit intodevelopfrom
fix-invoice-settings

Conversation

@apoorv-mishra
Copy link
Contributor

@apoorv-mishra apoorv-mishra commented Jun 3, 2022

Notion card

NA

Summary

Disallow connected param in create/update requests for payments providers since it is automatically set as true or false based on whether stripe(or paypal etc) connect flow is successful or not. It shouldn't be allowed to be set by users via API calls.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Current Code Coverage Percent of this PR:

87.13 %

Files having coverage below 100%

Impacted Files Coverage
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 95.45 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105 supriya3105 merged commit 8bfbd68 into develop Jun 3, 2022
@supriya3105 supriya3105 deleted the fix-invoice-settings branch June 3, 2022 13:17
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants