Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BE]Remove payments provider creation route#441

Merged
supriya3105 merged 1 commit intodevelopfrom
remove-create-action
Jun 3, 2022
Merged

[BE]Remove payments provider creation route#441
supriya3105 merged 1 commit intodevelopfrom
remove-create-action

Conversation

@apoorv-mishra
Copy link
Contributor

Notion card

NA

Summary

Remove POST /internal_api/v1/payments/providers since it's no longer needed. The providers, with their config are created based on the provider's integration success or failure.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Current Code Coverage Percent of this PR:

87.02 %

Files having coverage below 100%

Impacted Files Coverage
/app/policies/payments/provider_policy.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105 supriya3105 merged commit 60cb386 into develop Jun 3, 2022
@supriya3105 supriya3105 deleted the remove-create-action branch June 3, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants