Merged
Conversation
JijoBose
approved these changes
Jun 7, 2022
Current Code Coverage Percent of this PR:87.5 %Files having coverage below 100%
|
Collaborator
|
@ajinkyaa Notes are not aligned in my browser. |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Index client_id to elasticsearch * Use client id directly for filtering * Add service class for creating group-by es query * Add service class for processing aggregated ES data * Consider group-by while showing reports * Return formatted date labels for grouping by week * Add sorting as desc order by work_date * Add default filter of this_month duration * Fix reports request tests * Add specs for group_by service class * Add request specs for group by but without any filters * Add specs for group by and filter combinations * groupby filters added * label added * alignment issues resolved * alignment Co-authored-by: Shalaka Patil <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist: