Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Profile settings page#448

Merged
supriya3105 merged 36 commits intodevelopfrom
profile-react-app
Jun 9, 2022
Merged

Profile settings page#448
supriya3105 merged 36 commits intodevelopfrom
profile-react-app

Conversation

@onkar-saeloun
Copy link
Contributor

@onkar-saeloun onkar-saeloun commented Jun 7, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Redesign-Profile-settings-page-Integration-03e66940e98d4e39935108562dfedcff

Summary

  • Added page design for profile settings.
  • Added YUP validation for the necessary fields.
  • API integration is added.
  • Added Left sidebar for the Profile settings and rest of the settings pages.

Preview

Miru._.Time.tracking.and.invoicing.-.7.June.2022.mp4

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested Manually at my machine.
Testing involves following things-

  • Update button will be enabled only by making changes in any field otherwise it should be disabled.
  • Cancel button should remove all the unsaved changes.
  • Firstname, Lastname should be mandatory fields. After clicking on change password button, (current password, password and confirm password) will become mandatory fields.
  • password and confirm password should match on UI before submitting.
  • after deleting the profile image should be deleted.
  • changes should be updated after refreshing the page.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

sudeeptarlekar and others added 23 commits May 23, 2022 14:33
@sudeeptarlekar
Added shell UI for employee settings
f3e47a4 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added header to each page
f6e30af 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added user details in Side Nav bar
4de3b3c 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added profile edit page
136bdc9 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar
Added shell profile react app
a89d66d 
Signed-off-by: sudeeptarlekar <[email protected]>
@onkar-saeloun
added css changes in header
8e70cb2
@onkar-saeloun
added css changes for sidenavbar
acdf436
@onkar-saeloun
added divider
7cb6d7f
@onkar-saeloun
added functional and css changes to the profile component
001fd0f
@onkar-saeloun
added vertical height to tailwind config
797fa8f
@onkar-saeloun
added formatting
6d89ca6
@onkar-saeloun
fixed lintel errors
b29fb39
@onkar-saeloun
Merge branch 'develop' of github.com:saeloun/miru-web into profile-re…
26f9985 
…act-app

merging develop branch
@onkar-saeloun
added header file and refactored user details page
448d742
add api for profile update
3cb33d9
@onkar-saeloun
Merge branch 'profile-settings-api' of github.com:saeloun/miru-web in…
cdde26a 
…to profile-react-app

merging profile settings API page
add index action
536c7c8
send avatar in index action
fdb9adb
@onkar-saeloun
Merge branch 'profile-settings-api' of github.com:saeloun/miru-web in…
a1b091e 
…to profile-react-app

merging profile settings API
@onkar-saeloun
added APIs for integration
26632e6
@onkar-saeloun
added validation and integration for the APIs
a2689d5
@onkar-saeloun
removed password field
4b505f2
@onkar-saeloun
changed update btn validation
d5b8808
@onkar-saeloun onkar-saeloun self-assigned this Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

87.7 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/users/invitations_controller.rb 86.36 %
/app/policies/payments/provider_policy.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.1 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 8, 2022

@harshaanNihal @apoorv1316 Please review and test this PR respectively.

JijoBose
JijoBose reviewed Jun 8, 2022
View reviewed changes
JijoBose
JijoBose reviewed Jun 8, 2022
View reviewed changes
harshaanNihal
harshaanNihal reviewed Jun 8, 2022
View reviewed changes
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 9, 2022

@apoorv1316 Please test this PR and share your feedback if any.

@onkar-saeloun
Merge branch 'profile-settings-api' of github.com:saeloun/miru-web in…
8824e28 
…to profile-react-app

merging profile settings API
@apoorv1316
Copy link
Collaborator

apoorv1316 commented Jun 9, 2022 •
edited
Loading

@supriya3105 Already done on a call with Onkar. He has made all the required changes. Approving it.

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 9, 2022

@JijoBose Please review this PR .

@supriya3105 supriya3105 merged commit e004546 into develop Jun 9, 2022
@supriya3105 supriya3105 deleted the profile-react-app branch June 9, 2022 09:10
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@onkar-saeloun @sudeeptarlekar @akhilgkrishnan
Profile settings page (#448)
2fb9914 
* Added shell UI for employee settings

Signed-off-by: sudeeptarlekar <[email protected]>

* Added header to each page

Signed-off-by: sudeeptarlekar <[email protected]>

* Added user details in Side Nav bar

Signed-off-by: sudeeptarlekar <[email protected]>

* Added profile edit page

Signed-off-by: sudeeptarlekar <[email protected]>

* Added shell profile react app

Signed-off-by: sudeeptarlekar <[email protected]>

* added css changes in header

* added css changes for sidenavbar

* added divider

* added functional and css changes to the profile component

* added vertical height to tailwind config

* added formatting

* fixed lintel errors

* added header file and refactored user details page

* add api for profile update

* add index action

* send avatar in index action

* added APIs for integration

* added validation and integration for the APIs

* removed password field

* changed update btn validation

* added eslint fixes

* added alt to image

* add request specs

* fix review comments

* added code breaking

* added toaster and error message

* removed update msg from header

* use show action instead of index

* update spec notice

* changed css for label

Co-authored-by: sudeeptarlekar <[email protected]>
Co-authored-by: “Apoorv <“[email protected]”>
Co-authored-by: Akhil G Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JijoBose JijoBose JijoBose approved these changes

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@ajinkyaa ajinkyaa Awaiting requested review from ajinkyaa

+1 more reviewer

@harshaanNihal harshaanNihal harshaanNihal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@onkar-saeloun onkar-saeloun

Labels

feature PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@onkar-saeloun @supriya3105 @apoorv1316 @JijoBose @harshaanNihal @sudeeptarlekar @akhilgkrishnan