Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Filtered entries using timeframe#450

Merged
supriya3105 merged 2 commits intodevelopfrom
hours-on-project-details-page
Jun 7, 2022
Merged

Filtered entries using timeframe#450
supriya3105 merged 2 commits intodevelopfrom
hours-on-project-details-page

Conversation

@sudeeptarlekar
Copy link
Contributor

@sudeeptarlekar sudeeptarlekar commented Jun 7, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Hours-logged-by-team-members-are-not-displayed-on-the-project-details-page-d8eb05d1241e4c5b8220476ad73e7a15

Summary

Fetched entries for project based on time frame selected

Preview

project_entries

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

RSpecs for respective method are already written

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@pr-triage pr-triage bot added the PR: draft label Jun 7, 2022
@sudeeptarlekar sudeeptarlekar force-pushed the hours-on-project-details-page branch from 036d1ad to 9816a2a Compare June 7, 2022 12:23
@sudeeptarlekar sudeeptarlekar marked this pull request as ready for review June 7, 2022 12:24
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Current Code Coverage Percent of this PR:

87.51 %

Files having coverage below 100%

Impacted Files Coverage
/app/policies/payments/provider_policy.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.1 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

apoorv-mishra
apoorv-mishra approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supriya3105 supriya3105 merged commit f0ee8ee into develop Jun 7, 2022
@supriya3105 supriya3105 deleted the hours-on-project-details-page branch June 7, 2022 13:12
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@sudeeptarlekar
Filtered entries using timeframe (#450)
46a9429 
* Filtered entries using timeframe

Signed-off-by: sudeeptarlekar <[email protected]>

* Fixed error for blank entries

Signed-off-by: sudeeptarlekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@apoorv-mishra apoorv-mishra apoorv-mishra approved these changes

@supriya3105 supriya3105 supriya3105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sudeeptarlekar @apoorv-mishra @supriya3105