Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Invoice Date Format and icon #451

Merged
supriya3105 merged 3 commits intodevelopfrom
invoice-date-format
Jun 8, 2022
Merged

Fix Invoice Date Format and icon #451
supriya3105 merged 3 commits intodevelopfrom
invoice-date-format

Conversation

@harshaanNihal
Copy link
Contributor

@harshaanNihal harshaanNihal commented Jun 7, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/The-date-format-on-view-invoice-should-be-in-the-format-dd-mm-yyyy-0ce738de497341f888c086f6bcf8ccc5

Summary

  • Update date format to DD-MM-YYYY on invoice page.
  • update css to resolve icon cropping on safari browser.

Preview

Miru._.Time.tracking.and.invoicing.-.7.June.2022.mp4

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@pr-triage pr-triage bot added the PR: draft label Jun 7, 2022
@harshaanNihal
format date on invoice page
16dbb47
@harshaanNihal
Fix entrycard css
ba1bde5 
  - remove hardcoaded width
  - solve icon crop on safari bug
@harshaanNihal
update date format
e1e7a13
@harshaanNihal harshaanNihal force-pushed the invoice-date-format branch from 2c4d67d to e1e7a13 Compare June 7, 2022 13:58
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Current Code Coverage Percent of this PR:

87.51 %

Files having coverage below 100%

Impacted Files Coverage
/app/policies/payments/provider_policy.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.1 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@harshaanNihal harshaanNihal marked this pull request as ready for review June 7, 2022 14:21
@JijoBose
Copy link
Contributor

JijoBose commented Jun 7, 2022

Feel free to use https://www.loom.com/ for screen-recording, that way you only need to add a loom video link in the PR

@supriya3105 supriya3105 merged commit 04e2369 into develop Jun 8, 2022
@supriya3105 supriya3105 deleted the invoice-date-format branch June 8, 2022 07:24
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@harshaanNihal
Fix Invoice Date Format and icon (#451)
b8ff6c6 
* format date on invoice page

* Fix entrycard css
  - remove hardcoaded width
  - solve icon crop on safari bug

* update date format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JijoBose JijoBose JijoBose approved these changes

@apoorv1316 apoorv1316 apoorv1316 approved these changes

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshaanNihal @JijoBose @apoorv1316 @supriya3105