Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUGFIX]Allow invitation to another workspace#455

Merged
supriya3105 merged 1 commit intodevelopfrom
fix-workspace-invite
Jun 9, 2022
Merged

[BUGFIX]Allow invitation to another workspace#455
supriya3105 merged 1 commit intodevelopfrom
fix-workspace-invite

Conversation

@apoorv-mishra
Copy link
Contributor

@apoorv-mishra apoorv-mishra commented Jun 8, 2022

Notion card

NA

Summary

Currently, a user can't be invited to another workspace which is undesirable. This PR fixes it by overriding devise_invitable's default behaviour as per the docs.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@apoorv-mishra apoorv-mishra force-pushed the fix-workspace-invite branch from 373d6ec to d84c970 Compare June 8, 2022 12:14
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Current Code Coverage Percent of this PR:

86.92 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/users/invitations_controller.rb 86.36 %
/app/policies/payments/provider_policy.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105 supriya3105 merged commit b666e1f into develop Jun 9, 2022
@supriya3105 supriya3105 deleted the fix-workspace-invite branch June 9, 2022 05:31
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
[BUGFIX]Allow invitation to another workspace (#455)
3741a06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@rohitjoshixyz rohitjoshixyz Awaiting requested review from rohitjoshixyz

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

@keshavbiswa keshavbiswa Awaiting requested review from keshavbiswa

@sudeeptarlekar sudeeptarlekar Awaiting requested review from sudeeptarlekar

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apoorv-mishra @apoorv1316 @supriya3105