Merged
Conversation
supriya3105
approved these changes
Jun 8, 2022
Contributor
supriya3105
left a comment
There was a problem hiding this comment.
LGTM after fixing the CI checks that are failing
Contributor
|
@Shruti-Apte CI check is failing here. Please check and fix this rspec ./spec/requests/internal_api/v1/clients/show_spec.rb:24 # InternalApi::V1::Clients#show when user is admin when time_frame is week returns the total hours logged for a client in that week |
Current Code Coverage Percent of this PR:87.51 %Files having coverage below 100%
|
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Client details menu options added * resolved CI failure Co-authored-by: Shruti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Admin-should-be-able-to-add-a-new-project-edit-delete-a-client-from-a-the-client-details-page-676c9b3a6897458c97c45a3f3618f847
Summary
-Admin can add project
-Delete client
-Edit client from client details page.
Preview
https://www.loom.com/share/793e49e2b1a746f4bdd809e863a3aa91
Type of change
How Has This Been Tested?
Checklist: