Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Code refactor#458

Merged
supriya3105 merged 2 commits intodevelopfrom
add-utility-functions
Jun 13, 2022
Merged

Code refactor#458
supriya3105 merged 2 commits intodevelopfrom
add-utility-functions

Conversation

@sudeeptarlekar
Copy link
Contributor

Code Refactor

Signed-off-by: sudeeptarlekar <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Current Code Coverage Percent of this PR:

87.73 %

Files having coverage below 100%

Impacted Files Coverage
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the unrelated file. Thanks for working on this 👍 LGTM 🎉


require "rails_helper"

RSpec.describe Payments::ProviderPolicy, type: :policy do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, spec coverage was less, so thought will add here instead of creating extra PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@supriya3105 supriya3105 merged commit 215b0c6 into develop Jun 13, 2022
@supriya3105 supriya3105 deleted the add-utility-functions branch June 13, 2022 10:04
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
* Added common date range function

Signed-off-by: sudeeptarlekar <[email protected]>

* Added payments provider policy specs

Signed-off-by: sudeeptarlekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants