[BUGFIX]Allow user to be invited to multiple admins' workspaces#459
Merged
supriya3105 merged 1 commit intodevelopfrom Jun 10, 2022
Merged
[BUGFIX]Allow user to be invited to multiple admins' workspaces#459supriya3105 merged 1 commit intodevelopfrom
supriya3105 merged 1 commit intodevelopfrom
Conversation
| private | ||
|
|
||
| def invite_resource | ||
| if invited_user.present? && invited_user.invitation_accepted_at.present? |
Contributor
There was a problem hiding this comment.
Can you add a spec for this change?
Contributor
Author
There was a problem hiding this comment.
This is hard to test since the user has to accept invitation and that user has to be invited again. Moreover, @shalapatil is already re-working this out. I would suggest we go ahead with merge after @apoorv1316 approves.
apoorv1316
approved these changes
Jun 10, 2022
Contributor
|
@rohitjoshixyz Can we merge this as suggested by @apoorv-mishra ? |
Contributor
|
Okay go ahead @supriya3105 |
rohitjoshixyz
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
NA
Summary
A user can be invited to different admins' workspaces.
Preview
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: