Thanks to visit codestin.com
Credit goes to github.com

Skip to content

resolved cash formatter issue#460

Merged
supriya3105 merged 2 commits intodevelopfrom
bug-overdue-outstanding-amt
Jun 10, 2022
Merged

resolved cash formatter issue#460
supriya3105 merged 2 commits intodevelopfrom
bug-overdue-outstanding-amt

Conversation

@onkar-saeloun
Copy link
Contributor

@onkar-saeloun onkar-saeloun commented Jun 9, 2022

Notion card

https://www.notion.so/saeloun/Fix-the-overdue-and-oustanding-amount-displayed-on-the-client-details-page-31856b5d1ac140efb34b6f7a8377740c

Summary

Two issues:-

  • For undefined condition instead of returning amount in K format, the amount is now showing as 0.00
  • For amount less than 1000 i.e. 10 previously it was showing as 10.00 K but now it will show as 10.00 so no misguiding will be there.

Preview

Miru._.Time.tracking.and.invoicing.-.9.June.2022.mp4

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually tested against condition ranging from 0 - 1 M.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@onkar-saeloun onkar-saeloun requested a review from ajinkyaa June 9, 2022 12:07
@onkar-saeloun onkar-saeloun self-assigned this Jun 9, 2022
@onkar-saeloun onkar-saeloun added the bug Something isn't working label Jun 9, 2022
@onkar-saeloun onkar-saeloun requested a review from apoorv1316 June 9, 2022 12:07
@github-actions
Copy link

github-actions bot commented Jun 10, 2022

Current Code Coverage Percent of this PR:

87.7 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/users/invitations_controller.rb 86.36 %
/app/policies/payments/provider_policy.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.1 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105 supriya3105 merged commit 391d842 into develop Jun 10, 2022
@supriya3105 supriya3105 deleted the bug-overdue-outstanding-amt branch June 10, 2022 06:20
@pr-triage pr-triage bot added the PR: merged label Jun 10, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@onkar-saeloun @akhilgkrishnan
resolved cash formatter issue (#460)
fde83d3 
Co-authored-by: Akhil G Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@ajinkyaa ajinkyaa Awaiting requested review from ajinkyaa

Assignees

@onkar-saeloun onkar-saeloun

Labels

bug Something isn't working PR: merged PR: partially-approved PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@onkar-saeloun @apoorv1316 @supriya3105 @akhilgkrishnan