Merged
Conversation
- Add PNG equivalent of SVG icons
Contributor
Author
|
As I was testing it using localhost as domain the Although I have tried to use properties which have high support percentage The Layout may vary depending on mail service provider (Gmail, AOL, Outlook etc) and on their respective client (Browser, Desktop, Android) |
akhilgkrishnan
approved these changes
Jun 10, 2022
Member
akhilgkrishnan
left a comment
There was a problem hiding this comment.
LGTM, Thanks Harshaan for taking this up. Once we merged this we can together test this on staging.
Current Code Coverage Percent of this PR:87.7 %Files having coverage below 100%
|
Shruti-Apte
approved these changes
Jun 10, 2022
Contributor
Shruti-Apte
left a comment
There was a problem hiding this comment.
LGTM, Thank you so much @harshaanNihal for picking this up!
Next time I'll keep in my mind not to use modern CSS in mailers.
apoorv1316
approved these changes
Jun 10, 2022
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
- Add PNG equivalent of SVG icons Co-authored-by: Akhil G Krishnan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
NA
Summary
Preview
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
NA