Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Invoice Email Design Fix#462

Merged
supriya3105 merged 2 commits intodevelopfrom
bug/invoice-email-format-fix
Jun 10, 2022
Merged

Invoice Email Design Fix#462
supriya3105 merged 2 commits intodevelopfrom
bug/invoice-email-format-fix

Conversation

@harshaanNihal
Copy link
Contributor

@harshaanNihal harshaanNihal commented Jun 9, 2022

Notion card

NA

Summary

  • Design Fixes for Invoice email
  • using PNG icons instead of SVG as SVG is not supported by Gmail.
  • Update design to use tables and float instead of flex as flex is not supported by most email client

Preview

Screenshot 2022-06-10 at 4 07 04 AM Local Opeaner

Screenshot 2022-06-10 at 4 11 32 AM Macbook Mail Client

Screenshot 2022-06-10 at 4 14 11 AM Gmail Browser Client

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

NA

  - Add PNG equivalent of SVG icons
@harshaanNihal
Copy link
Contributor Author

harshaanNihal commented Jun 9, 2022

As I was testing it using localhost as domain the Saeloun logo is not rendering in Gmail Browser Client in above images.
It should not be the case if we are in Staging or Production environment.

Although I have tried to use properties which have high support percentage The Layout may vary depending on mail service provider (Gmail, AOL, Outlook etc) and on their respective client (Browser, Desktop, Android)

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Harshaan for taking this up. Once we merged this we can together test this on staging.

@github-actions
Copy link

Current Code Coverage Percent of this PR:

87.7 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/users/invitations_controller.rb 86.36 %
/app/policies/payments/provider_policy.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/report/filters.rb 87.1 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggessions

Copy link
Contributor

@Shruti-Apte Shruti-Apte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you so much @harshaanNihal for picking this up!
Next time I'll keep in my mind not to use modern CSS in mailers.

@supriya3105 supriya3105 merged commit c120d67 into develop Jun 10, 2022
@supriya3105 supriya3105 deleted the bug/invoice-email-format-fix branch June 10, 2022 06:17
@harshaanNihal harshaanNihal mentioned this pull request Jun 15, 2022
4 tasks
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
- Add PNG equivalent of SVG icons

Co-authored-by: Akhil G Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants