Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Project edit issue#469

Merged
apoorv1316 merged 8 commits intodevelopfrom
project-id-issue
Jun 22, 2022
Merged

Project edit issue#469
apoorv1316 merged 8 commits intodevelopfrom
project-id-issue

Conversation

@abinashpa
Copy link
Contributor

@abinashpa abinashpa commented Jun 13, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/6afc9500b2cc42af86be55f37894fb09?v=f1810139870444259ef38b4bee169b34&p=2e3337478aec42818dbaca5f4ba3c1f5

Summary

The page is breaking after clicking on edit project details

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@abinashpa abinashpa requested a review from akhilgkrishnan June 13, 2022 18:59
@abinashpa abinashpa added bug Something isn't working frontend labels Jun 13, 2022
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

89.24 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105 supriya3105 requested a review from apoorv1316 June 14, 2022 08:47
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 14, 2022

@apoorv1316 Please test the fix for the bug found on production.

ajinkyaa
ajinkyaa reviewed Jun 14, 2022
View reviewed changes
ajinkyaa
ajinkyaa reviewed Jun 14, 2022
View reviewed changes
@abinashpa abinashpa self-assigned this Jun 15, 2022
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 15, 2022

@ajinkyaa @akhilgkrishnan Please review this PR. Abinash has responded to your questions.
@apoorv1316 Please test this.

apoorv1316
apoorv1316 requested changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abinashpa Screenshot 2022-06-17 at 9 29 14 AM
Getting this error on the projects page. Please fix it.

akhilgkrishnan
akhilgkrishnan reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abinashpa what's the use of helix file?

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 20, 2022

@apoorv1316 Please test this and merge if the functionality is working.

@apoorv1316
Copy link
Collaborator

apoorv1316 commented Jun 20, 2022

@supriya3105 2-3 things need to be fixed. I have talked and conveyed it to Abhinash already and he is working on it.

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 20, 2022

@supriya3105 2-3 things need to be fixed. I have talked and conveyed it to Abhinash already and he is working on it.

Please add the feedback your have provided to the PR.

akhilgkrishnan
akhilgkrishnan approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apoorv1316 apoorv1316 merged commit 0ba40a4 into develop Jun 22, 2022
@apoorv1316 apoorv1316 deleted the project-id-issue branch June 22, 2022 05:11
@pr-triage pr-triage bot added the PR: merged label Jun 22, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Project edit issue (#469)
c56e906 
* AddEditProject.tsx changes has been added

* repace filter with map in project-id-issue

* removed unused foleder helix

* variable e changed to event in project-id-issue

* migration ran in project-id-issue

* Fixes forcrashing in /projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

+1 more reviewer

@ajinkyaa ajinkyaa ajinkyaa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abinashpa abinashpa

Labels

bug Something isn't working frontend PR: merged PR: partially-approved PR: reviewed-approved PR: reviewed-changes-requested PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abinashpa @supriya3105 @apoorv1316 @ajinkyaa @akhilgkrishnan