Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Email Verification Window - Backend#470

Merged
supriya3105 merged 4 commits intodevelopfrom
bugfix/email-verification-window
Jun 14, 2022
Merged

Email Verification Window - Backend#470
supriya3105 merged 4 commits intodevelopfrom
bugfix/email-verification-window

Conversation

@harshaanNihal
Copy link
Contributor

@harshaanNihal harshaanNihal commented Jun 13, 2022 •
edited
Loading

Notion card

REF: https://www.notion.so/saeloun/Once-the-user-signs-up-email-verification-window-shou[…]e-displayed-as-per-the-design-aeef4cccf92042c4bca82023aa68e9c9

Summary

  • Earlier the routing for Unconfirmed User was handled directly by Devise
  • Override Device:FailureApp to add custom handler
  • the Verification Screen will be replace with a React component as per the Design in a Separate PR.

Preview

https://www.loom.com/share/cc2059d3a80f4c459426a948aa637533

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@pr-triage pr-triage bot added the PR: draft label Jun 13, 2022
@harshaanNihal harshaanNihal force-pushed the bugfix/email-verification-window branch from 0a54201 to 06ab23e Compare June 13, 2022 21:14
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

89.18 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@akhilgkrishnan akhilgkrishnan added the bug Something isn't working label Jun 14, 2022
@harshaanNihal harshaanNihal force-pushed the bugfix/email-verification-window branch from 23beb9a to 1712234 Compare June 14, 2022 09:38
@harshaanNihal harshaanNihal changed the title Email Verification Window Email Verification Window - Backend Jun 14, 2022
harshaanNihal
harshaanNihal commented Jun 14, 2022
View reviewed changes
app/views/email_confirmations/show.html.erb
Comment on lines +1 to +4
<br/>
<br/>
<h1><%= user.email %></h1>
<a href="<%= resend_url %>">resend</a>
Copy link
Contributor Author

@harshaanNihal harshaanNihal Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this file so that it wont break the flow. this file will be replaced by a React Component as per the design in a separate PR.

@harshaanNihal harshaanNihal marked this pull request as ready for review June 14, 2022 10:14
@supriya3105 supriya3105 requested review from onkar-saeloun and rohitjoshixyz and removed request for Shruti-Apte June 14, 2022 11:02
onkar-saeloun
onkar-saeloun approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@onkar-saeloun onkar-saeloun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105 supriya3105 merged commit fb56f33 into develop Jun 14, 2022
@supriya3105 supriya3105 deleted the bugfix/email-verification-window branch June 14, 2022 16:45
@pr-triage pr-triage bot added the PR: merged label Jun 14, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@harshaanNihal
Email Verification Window - Backend (#470)
a5835ef 
* Override Devise:FailureApp with custom_failure

* Add Email Confirmation controller and routes

* Add resend email confirmation functionality

* Add specs and code refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

@rohitjoshixyz rohitjoshixyz Awaiting requested review from rohitjoshixyz

1 more reviewer

@onkar-saeloun onkar-saeloun onkar-saeloun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working PR: draft PR: merged PR: partially-approved PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshaanNihal @onkar-saeloun @akhilgkrishnan @supriya3105