Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Toaster and interceptor issue#472

Merged
akhilgkrishnan merged 5 commits intodevelopfrom
toaster-issue
Jun 14, 2022
Merged

Toaster and interceptor issue#472
akhilgkrishnan merged 5 commits intodevelopfrom
toaster-issue

Conversation

@onkar-saeloun
Copy link
Contributor

@onkar-saeloun onkar-saeloun commented Jun 14, 2022

Notion card

Summary

There was an issue under setting page layout that each page has its own interceptor so toaster messages were increasing as we go to the different tabs

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested Manually on my machine

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@onkar-saeloun onkar-saeloun self-assigned this Jun 14, 2022
@onkar-saeloun
Copy link
Contributor Author

onkar-saeloun commented Jun 14, 2022

@sudeeptarlekar can you please verify and test your changes on add bank account details page.

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Current Code Coverage Percent of this PR:

89.12 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/users/invitations_controller.rb 86.36 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

sudeeptarlekar
sudeeptarlekar approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@sudeeptarlekar sudeeptarlekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akhilgkrishnan
akhilgkrishnan approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilgkrishnan akhilgkrishnan merged commit 11d40b6 into develop Jun 14, 2022
@akhilgkrishnan akhilgkrishnan deleted the toaster-issue branch June 14, 2022 07:40
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@onkar-saeloun
Toaster and interceptor issue (#472)
bdb665f 
* added setAuth Header and intersepter in parent component

* removed set auth header and register inteceptors

* removed auth headers and register interceptors

* removed toaster setauth header

* removed register header and interceptors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

+1 more reviewer

@sudeeptarlekar sudeeptarlekar sudeeptarlekar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@onkar-saeloun onkar-saeloun

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onkar-saeloun @akhilgkrishnan @sudeeptarlekar