Codestin Search App

mohinid · 2022-06-14T10:54:19Z

Notion card

https://www.notion.so/saeloun/Add-tables-for-personal-employment-Allocated-devices-compensation-71ef49d0c38e4242bd2998120141372d

Summary

Added new columns(personal_email_id, date_of_birth & social_accounts) to Users table.
DATA MIGRATION- Updated default empty string values to Social Account URLs(github_url, linkedin_url) for existing Data.
Added "UserDefaultSocialAccountVerifier" - verification file for data migration.
Added rspec for new changes in User model.

Preview

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on Local Rails console.

Checklist:

I have manually tested all workflows
I have performed a self-review of my own code
I have added automated tests for my code

apoorv-mishra · 2022-06-14T11:19:05Z

app/models/user.rb

 #  reset_password_sent_at :datetime
 #  reset_password_token   :string
 #  sign_in_count          :integer          default(0), not null
+#  social_accounts        :jsonb


I would suggest to have a separate model for social_accounts with a has_many :social_accounts association on User model. Fits well with the relational model.

@rohitjoshixyz can you please comment.

We decided to go ahead with a JSON field type @apoorv-mishra so that it will be easier for us to add more social links without migrating DB columns. Also, we only need to store links as names and URLs as strings which we could nicely store in a JSON. It will also avoid a join query.

rohitjoshixyz · 2022-06-14T12:31:31Z

app/models/user.rb

+  store_accessor :social_accounts, :github_url, :linkedin_url
+
  # Validations
+  before_validation :set_default_social_accounts, on: :create


Can you comment on why did you choose the before_validation callback? I think we can have it after_create

Also, we are not checking if the URLs already exist in the object. Wouldn't this overwrite the URLs we actually want to save?

Hey, @akhilgkrishnan suggested creating empty strings by default when the User object is created. @akhilgkrishnan please comment.

I think, In this case, I don't think we need an after_create. The problem with after_create it actually write the DB multiple times.
One for creating the user entry, another write for updating the social_account. before_validation or before_create is suitable for here, because they are just initializing the value and not creating an entry for the DB.

Let's go ahead with before_create 👍

rohitjoshixyz · 2022-06-14T12:43:59Z

db/data/20220614094240_add_personal_detail_fields_to_users.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require_relative("./verifiers/user_default_social_account_verifier.rb")


Do we need this to be in a separate directory? We could just write the method in the migration itself. Could you post any blog or tutorial you followed for this over here for my reference?

Hi, its created so that we can add more verifiers for future data migrations.

rohitjoshixyz · 2022-06-14T13:32:34Z

app/models/user.rb

+  def set_default_social_accounts
+    self.social_accounts = {
+      "github_url": "",
+      "linkedin_url": ""
+    }
+  end
+


@mohinid Creating empty strings is fine. before_validation :set_default_social_accounts, on: :create can be replaced with before_create as it would be equivalent and I think it should be after_create cc @akhilgkrishnan

Yes, before_create also works

@akhilgkrishnan @rohitjoshixyz what is the final conclusion? before_create or before_validation?

Go with before_create

@akhilgkrishnan @rohitjoshixyz I am using "after_initialize" with a check of new_record. It creates social_accounts with empty URLs because 'before_create' is generating an empty social_accounts object.

Tested this by updating the github_url of the first record, as well as running RSpecs. Here is the SS.

akhilgkrishnan · 2022-06-14T14:18:55Z

app/models/user.rb

 #  updated_at             :datetime         not null
 #  current_workspace_id   :bigint
 #  invited_by_id          :bigint
+#  personal_email_id      :string


@mohinid Still got confused with this field. What's the exact difference of the actual email and this one.

This is the personal Email Id as of the user just for reference. Like an alternative email. Screenshot attached in the notion task.

github-actions · 2022-06-14T15:35:40Z

Current Code Coverage Percent of this PR:

89.15 %

Files having coverage below 100%

Impacted Files	Coverage
/app/controllers/users/invitations_controller.rb	86.36 %
/app/services/invoice_payment/checkout.rb	44.0 %
/app/services/invoice_payment/pdf_generation.rb	70.97 %
/app/controllers/internal_api/v1/companies_controller.rb	95.45 %
/app/controllers/internal_api/v1/profile_controller.rb	96.88 %
/app/controllers/internal_api/v1/payment_settings_controller.rb	93.33 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb	90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb	94.74 %
/lib/benchmarking/benchmarker.rb	0.0 %

rohitjoshixyz

LGTM, I like the before_initialize callback 👍

* Adds new personal detail fields to Users table * update callback to after_initialize Co-authored-by: Akhil G Krishnan <[email protected]>

Adds new personal detail fields to Users table

21e9100

mohinid added the feature label Jun 14, 2022

mohinid requested review from akhilgkrishnan and rohitjoshixyz June 14, 2022 10:54

mohinid self-assigned this Jun 14, 2022

pr-triage bot added the PR: unreviewed label Jun 14, 2022

apoorv-mishra reviewed Jun 14, 2022

View reviewed changes

rohitjoshixyz reviewed Jun 14, 2022

View reviewed changes

akhilgkrishnan reviewed Jun 14, 2022

View reviewed changes

update callback to after_initialize

f917c22

rohitjoshixyz approved these changes Jun 14, 2022

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jun 14, 2022

Merge branch 'develop' into add-fields-to-users-table

d9ddab8

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Jun 14, 2022

akhilgkrishnan merged commit 28b0097 into develop Jun 14, 2022

akhilgkrishnan deleted the add-fields-to-users-table branch June 14, 2022 16:15

pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 14, 2022

vipulnsward pushed a commit that referenced this pull request Feb 15, 2026

Adds new personal detail fields to Users table (#473)

9839b8b

* Adds new personal detail fields to Users table * update callback to after_initialize Co-authored-by: Akhil G Krishnan <[email protected]>

		@@ -0,0 +1,17 @@
		# frozen_string_literal: true

		require_relative("./verifiers/user_default_social_account_verifier.rb")

Conversation

mohinid commented Jun 14, 2022

Notion card

Summary

Preview

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohinid Jun 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 14, 2022

Current Code Coverage Percent of this PR:

89.15 %

Files having coverage below 100%

Uh oh!

rohitjoshixyz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mohinid Jun 14, 2022 •

edited

Loading