Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update the cypress specs#475

Merged
apoorv1316 merged 6 commits intodevelopfrom
update-cypress-specs
Jul 7, 2022
Merged

Update the cypress specs#475
apoorv1316 merged 6 commits intodevelopfrom
update-cypress-specs

Conversation

@apoorv1316
Copy link
Collaborator

@apoorv1316 apoorv1316 commented Jun 15, 2022

Summary

The cypress tests that are written need to be updated because of the changes done in the app.

Screenshot 2022-07-07 at 10 23 37 AM

@github-actions
Copy link

github-actions bot commented Jun 15, 2022

Current Code Coverage Percent of this PR:

89.25 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 92.86 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apoorv1316 Can you add the cypress test in our CI. I think we were removed that previosly

@apoorv1316
Copy link
Collaborator Author

@akhilgkrishnan Yes will do that!

@apoorv1316 apoorv1316 reopened this Jul 6, 2022
@apoorv1316 apoorv1316 requested a review from mohinid July 6, 2022 08:24
@apoorv1316
Copy link
Collaborator Author

@mohinid Updating old specs as per the changes made in the app.

@apoorv1316 apoorv1316 removed the WIP label Jul 6, 2022
@apoorv1316
Copy link
Collaborator Author

@mohinid Please review it.

Copy link
Contributor

@mohinid mohinid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LKTM! :)
Screenshot 2022-07-07 at 12 56 30 PM

@apoorv1316 apoorv1316 merged commit 74326f2 into develop Jul 7, 2022
@apoorv1316 apoorv1316 deleted the update-cypress-specs branch July 7, 2022 07:29
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
* fix old auth and root specs

* update spec for inviting user

* code cleanup

Co-authored-by: “Apoorv <“[email protected]”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants