Merged
Conversation
onkar-saeloun
commented
Jun 15, 2022
| <div className="w-20 h-20 border rounded border-miru-han-purple-1000 mt-2"> | ||
| <label htmlFor="file-input" className="flex justify-center items-cente w-full h-full cursor-pointer"> | ||
| <img src={img} alt="file_input" className="object-none" /> | ||
| {isLoading ? <Loader /> : ( |
Contributor
Author
There was a problem hiding this comment.
Just added conditional rendering for loader here. Rest of the changes showing because of indentation. Same for user details page
JijoBose
approved these changes
Jun 15, 2022
Contributor
|
@apoorv1316 Please test this. |
Contributor
|
@AkashKale Can you verify this implementation from design perspective. I have tested it locally on Onkar's system. |
supriya3105
approved these changes
Jun 16, 2022
Contributor
|
@akash K Can you review this PR with Onkar ? |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* added loader * added loader in organization page * added loader to userdetails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Implementation-of-Loader-Front-end-f01c57c40ce24f2db2814692a2c47761
Summary
Preview
Miru._.Time.tracking.and.invoicing.-.15.June.2022.mp4
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested Manually on local machine.
Checklist: