Conversation
added 8 commits
June 3, 2022 11:02
supriya3105
approved these changes
Jun 15, 2022
Contributor
|
@apoorv1316 Please test this flow. This also includes the fix for the bug raised by you https://www.notion.so/saeloun/Request-failed-error-toast-on-add-manual-entry-d5cebc12bffc4dd48abeb72a0bf3c51d. |
Contributor
|
@sudeeptarlekar @ajinkyaa Please review this PR. |
Contributor
|
@gowsik-ragunath As discussed please check below issues : |
added 4 commits
June 16, 2022 15:48
Current Code Coverage Percent of this PR:89.24 %Files having coverage below 100%
|
Contributor
Author
|
@supriya3105 I have fixed the issue in adding decimal values in the |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Fixed the issue in considering line item values for price calculation * Fixed the issue in setting the manual line item entry with updated values * Included manual line item entries in invoice amount calculation * Added ability to add multiple line items in generate invoice page * Fixed the issue in adding multiple line items in generate invoice page * Added option to delete a manual line item * Fixed the issue in update the line item date * Fixed the issue in adding decimal value in quantity field * Fixed the issue in loading company logo when logo is not present and grover dev environment issue * Fixed the issue in calcualting the invoice total Co-authored-by: Gowsik <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Manual-line-item-added-to-the-invoice-is-not-getting-saved-73c03eab24cb4a2f82bc39b58487b98e
https://www.notion.so/saeloun/Request-failed-error-toast-on-add-manual-entry-d5cebc12bffc4dd48abeb72a0bf3c51d
Summary
enterto add a manual line item in the invoice.Addition bug fix:
Preview
https://www.loom.com/share/ba4b98713ae14759a99d5fa10c611a3e
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: