Added external view key data migration for existing invoices#480
Merged
aniketkaushik merged 4 commits intodevelopfrom Jun 15, 2022
Merged
Conversation
Current Code Coverage Percent of this PR:89.24 %Files having coverage below 100%
|
keshavbiswa
requested changes
Jun 15, 2022
Contributor
keshavbiswa
left a comment
There was a problem hiding this comment.
Requested changes with the messaging.
db/data/verifiers/invoice_default_external_view_key_verifier.rb
Outdated
Show resolved
Hide resolved
db/data/verifiers/invoice_default_external_view_key_verifier.rb
Outdated
Show resolved
Hide resolved
akhilgkrishnan
approved these changes
Jun 15, 2022
Member
akhilgkrishnan
left a comment
There was a problem hiding this comment.
LGTM. Please verify manually the changes are reflected in your local or not. You can run the data migration by running ' rails data:migrate'
Contributor
Author
yes, it's working |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* added external view key data migration for existing invoice * added verify! to InvoiceDefaultExternalViewKeyVerifier * updated messages * minor fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve error in staging | undefined method `external_view_key'