Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Redirect to email verification window#484

Merged
supriya3105 merged 4 commits intodevelopfrom
Bug/redirect_to_email_verification_window
Jun 20, 2022
Merged

Redirect to email verification window#484
supriya3105 merged 4 commits intodevelopfrom
Bug/redirect_to_email_verification_window

Conversation

@Shruti-Apte
Copy link
Contributor

@Shruti-Apte Shruti-Apte commented Jun 16, 2022

Notion card

https://www.notion.so/saeloun/Once-the-user-signs-up-email-verification-window-should-be-displayed-as-per-the-design-aeef4cccf92042c4bca82023aa68e9c9

Summary

  • Email verification window design
  • Redirecting to email verification window after sign up

Preview

https://www.loom.com/share/e3043ed8e72a41649d53f83da7fa2c92

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code

@Shruti-Apte Shruti-Apte added the bug Something isn't working label Jun 16, 2022
@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

89.18 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/lib/benchmarking/benchmarker.rb 0.0 %

harshaanNihal
harshaanNihal suggested changes Jun 16, 2022
View reviewed changes
harshaanNihal
harshaanNihal approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@harshaanNihal harshaanNihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@supriya3105 supriya3105 requested a review from apoorv1316 June 20, 2022 07:59
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 20, 2022

@apoorv1316 Please test this flow and merge if working as expected. Its known that the toast message is still getting displayed after the verification which needs to be fixed by @harshaanNihal

@supriya3105 supriya3105 merged commit c9faa4c into develop Jun 20, 2022
@supriya3105 supriya3105 deleted the Bug/redirect_to_email_verification_window branch June 20, 2022 12:04
@pr-triage pr-triage bot added the PR: merged label Jun 20, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@Shruti-Apte
Redirect to email verification window (#484)
82df3ab 
* Email verification window design

* Backend Integration and esc eventlistener added

* Resolved conflicts

* Resolved comments

Co-authored-by: Shruti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@supriya3105 supriya3105 Awaiting requested review from supriya3105

+2 more reviewers

@harshaanNihal harshaanNihal harshaanNihal approved these changes

@onkar-saeloun onkar-saeloun onkar-saeloun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working Do not merge PR: merged PR: partially-approved PR: reviewed-changes-requested PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Shruti-Apte @supriya3105 @apoorv1316 @harshaanNihal @onkar-saeloun