Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Delete entry issue for admin#488

Merged
apoorv1316 merged 3 commits intodevelopfrom
delete-entry-admin-issue
Jun 20, 2022
Merged

Delete entry issue for admin#488
apoorv1316 merged 3 commits intodevelopfrom
delete-entry-admin-issue

Conversation

@abinashpa
Copy link
Contributor

@abinashpa abinashpa commented Jun 16, 2022 •
edited
Loading

Notion card

Summary

When an admin deletes a timesheet entry it is deleted but after switching to the different employee and coming back it is still showing the deleted timesheet entry.

Preview

https://www.loom.com/share/8c5c5d04f86a4c009fd27028a03eae05

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@abinashpa abinashpa added bug Something isn't working frontend labels Jun 16, 2022
@abinashpa abinashpa requested a review from akhilgkrishnan June 16, 2022 17:07
@abinashpa abinashpa self-assigned this Jun 16, 2022
@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

89.28 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/lib/benchmarking/benchmarker.rb 0.0 %

akhilgkrishnan
akhilgkrishnan reviewed Jun 17, 2022
View reviewed changes
@supriya3105 supriya3105 requested a review from apoorv1316 June 17, 2022 08:35
@abinashpa abinashpa requested a review from akhilgkrishnan June 20, 2022 05:54
@apoorv1316 apoorv1316 merged commit 39cd456 into develop Jun 20, 2022
@apoorv1316 apoorv1316 deleted the delete-entry-admin-issue branch June 20, 2022 06:58
@pr-triage pr-triage bot added the PR: merged label Jun 20, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@akhilgkrishnan
Delete entry issue for admin (#488)
b1f8de7 
* patch added for delete entry for admin

* variable name nv changed to newValue

Co-authored-by: Akhil G Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

Assignees

@abinashpa abinashpa

Labels

bug Something isn't working frontend PR: merged PR: partially-approved PR: reviewed-approved PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abinashpa @apoorv1316 @akhilgkrishnan