Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added Payment settings Page #493

Merged
supriya3105 merged 7 commits intodevelopfrom
payment-settings
Jun 17, 2022
Merged

Added Payment settings Page #493
supriya3105 merged 7 commits intodevelopfrom
payment-settings

Conversation

@onkar-saeloun
Copy link
Contributor

@onkar-saeloun onkar-saeloun commented Jun 17, 2022

Notion card

Summary

Added Payment Settings Page as payment page was not appearing in new settings feature.

Preview

Miru._.Time.tracking.and.invoicing.-.17.June.2022.mp4

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested Manually on local machine. Needs to test properly with QA.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code

@onkar-saeloun onkar-saeloun self-assigned this Jun 17, 2022
@onkar-saeloun onkar-saeloun changed the title Payment settings Page in Settings Added Payment settings Page Jun 17, 2022
apoorv1316
apoorv1316 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkar-saeloun It looks okay but can we add a loader since it takes a few seconds to load the payment settings.

@onkar-saeloun
Copy link
Contributor Author

onkar-saeloun commented Jun 17, 2022

@onkar-saeloun It looks okay but can we add a loader since it takes a few seconds to load the payment settings.

Yes @apoorv1316 even I am thinking so, this was on priority thats why raised PR if I will be able to add loader till EOD will push in same PR.

akhilgkrishnan
akhilgkrishnan reviewed Jun 17, 2022
View reviewed changes
app/javascript/src/components/Profile/Organization/Payment/index.tsx Outdated
Comment on lines 44 to 45
setAuthHeaders();
registerIntercepts();
Copy link
Member

@akhilgkrishnan akhilgkrishnan Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move these to profile routes

Copy link
Contributor Author

@onkar-saeloun onkar-saeloun Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup Thanks.

akhilgkrishnan
akhilgkrishnan reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onkar-saeloun I think we already have a payment_setting component. if we are not using that then please remove

@onkar-saeloun
Copy link
Contributor Author

onkar-saeloun commented Jun 17, 2022

@onkar-saeloun I think we already have a payment_setting component. if we are not using that then please remove

@apoorv-mishra should we remove it?

@github-actions
Copy link

github-actions bot commented Jun 17, 2022

Current Code Coverage Percent of this PR:

89.28 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 17, 2022

@apoorv1316 Can you test this again.

apoorv-mishra
apoorv-mishra approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supriya3105 supriya3105 merged commit 56738a3 into develop Jun 17, 2022
@supriya3105 supriya3105 deleted the payment-settings branch June 17, 2022 14:15
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@onkar-saeloun
Added Payment settings Page (#493)
e856b5a 
* changed payment settings name

* changed route in nav bar

* added payment settings page

* added loader

* removed interceptors from child component as it is present on parent

* removing payment-settings component

* removed payment settings import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@Shruti-Apte Shruti-Apte Awaiting requested review from Shruti-Apte

@supriya3105 supriya3105 Awaiting requested review from supriya3105

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

+1 more reviewer

@apoorv-mishra apoorv-mishra apoorv-mishra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@onkar-saeloun onkar-saeloun

Labels

frontend PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@onkar-saeloun @supriya3105 @apoorv-mishra @apoorv1316 @akhilgkrishnan