Merged
Conversation
JijoBose
approved these changes
Jun 20, 2022
Contributor
|
@ajinkyaa Please review this PR. |
ajinkyaa
suggested changes
Jun 21, 2022
| await profileApi.update(formD); | ||
| setIsDetailUpdated(false); | ||
| setErrDetails(initialErrState); | ||
| setUserState("profileSettings", { |
Contributor
There was a problem hiding this comment.
What if API fails? it will still update the profile setting context.
Once API updates should send the response, please check and update accordingly.
Please check and update accordingly to the 200 status.
Contributor
Author
There was a problem hiding this comment.
@ajinkyaa I have wrapped this API call with try catch block so it will take care of API failure.
| setUserState: (key, value) => { } //eslint-disable-line | ||
| })); | ||
|
|
||
| export const useEntry = () => useContext(EntryContext); |
Contributor
There was a problem hiding this comment.
change the name, it's not the entry page.
keep it useProfile something.
Current Code Coverage Percent of this PR:89.28 %Files having coverage below 100%
|
Contributor
|
@ajinkyaa Please review the PR again. Onkar has resolved your feedback comments. |
ajinkyaa
approved these changes
Jun 22, 2022
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* added context to layout * added context state management * addiing context state in userdetails page * resolved comment * added loader false on error * added status validation for context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Implementation-of-Context-for-settings-pages-94b4f7c80908450fa6e647cb1b49727f
Summary
Preview
Miru._.Time.tracking.and.invoicing.-.20.June.2022.mp4
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested Manually on my local machine.
Checklist: