Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update PreviousEmployment reference and Table name#500

Merged
mohinid merged 2 commits intodevelopfrom
update-previous-employment-details-references
Jun 21, 2022
Merged

Update PreviousEmployment reference and Table name#500
mohinid merged 2 commits intodevelopfrom
update-previous-employment-details-references

Conversation

@mohinid
Copy link
Contributor

@mohinid mohinid commented Jun 20, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Add-tables-for-personal-employment-Allocated-devices-compensation-71ef49d0c38e4242bd2998120141372d

Summary

  1. Removed association between EmploymentDetail and PreviousEmploymentDetail.
  2. Renamed PreviousEmploymentDetail to PreviousEmployment to be consistent in naming.
  3. Updated RSpecs.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on local Rails console as well as RSpecs

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@mohinid mohinid added the enhancement New feature or request label Jun 20, 2022
@mohinid mohinid self-assigned this Jun 20, 2022
@github-actions
Copy link

github-actions bot commented Jun 20, 2022

Current Code Coverage Percent of this PR:

89.34 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/lib/benchmarking/benchmarker.rb 0.0 %

keshavbiswa
keshavbiswa reviewed Jun 20, 2022
View reviewed changes
apoorv-mishra
apoorv-mishra reviewed Jun 20, 2022
View reviewed changes
apoorv-mishra
apoorv-mishra approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@apoorv-mishra apoorv-mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

rohitjoshixyz
rohitjoshixyz approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

keshavbiswa
keshavbiswa approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@keshavbiswa keshavbiswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohinid mohinid merged commit c971f28 into develop Jun 21, 2022
@mohinid mohinid deleted the update-previous-employment-details-references branch June 21, 2022 08:08
@pr-triage pr-triage bot added the PR: merged label Jun 21, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Update PreviousEmployment reference and Table name (#500)
81a651e 
* update PreviousEmployment reference and table name

* Remove unrelated changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

@keshavbiswa keshavbiswa keshavbiswa approved these changes

+2 more reviewers

@apoorv-mishra apoorv-mishra apoorv-mishra approved these changes

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mohinid mohinid

Labels

enhancement New feature or request PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mohinid @apoorv-mishra @akhilgkrishnan @rohitjoshixyz @keshavbiswa