Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Edit/delete existing line items#501

Merged
supriya3105 merged 8 commits intodevelopfrom
fixed-edit-delete-line-items
Jun 24, 2022
Merged

Edit/delete existing line items#501
supriya3105 merged 8 commits intodevelopfrom
fixed-edit-delete-line-items

Conversation

@gowsik-ragunath
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath commented Jun 20, 2022

Notion card

Summary

  • Fixed the issue in editing and deleting existing line items.
  • Existing line items can be added without pressing the Enter key.

Preview

https://www.loom.com/share/fb6f2e070f32471b8f91be46e6653d34

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented Jun 20, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

88.64 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 21, 2022

@apoorv1316 Please test the complete invoice functionality for this PR.

@apoorv1316
Copy link
Collaborator

apoorv1316 commented Jun 22, 2022

@gowsik-ragunath After editing a line item it remains in the editing state. Can we do something about it? Also on the edit invoice, there seems to be a CSS issue after editing the line item. Please check the video and let me know if you need more clarity on it. https://www.loom.com/share/e15ff2f89374470bb32bdee8f37090ab

@gowsik-ragunath
Copy link
Contributor Author

gowsik-ragunath commented Jun 22, 2022

@apoorv1316 I've fixed the issue in toggling between line item edit and view.

Demo: https://www.loom.com/share/f74f31f8a4f849fdbb5a4d93fb3ab284

sudeeptarlekar
sudeeptarlekar approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@sudeeptarlekar sudeeptarlekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good

@supriya3105 supriya3105 merged commit 68742c0 into develop Jun 24, 2022
@supriya3105 supriya3105 deleted the fixed-edit-delete-line-items branch June 24, 2022 06:24
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@gowsik-ragunath
Edit/delete existing line items (#501)
ff8e37a 
* Added ability to edit line items without pressing enter

* Added option to delete line item in edit invoice page

* Added option to delete the line item while editing

* Fixed the issue in displaying the due amount

* Removed default amount paid value

* Added logic to toggle between edit and view mode

Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@ajinkyaa ajinkyaa Awaiting requested review from ajinkyaa

@supriya3105 supriya3105 Awaiting requested review from supriya3105

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

+1 more reviewer

@sudeeptarlekar sudeeptarlekar sudeeptarlekar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gowsik-ragunath @supriya3105 @apoorv1316 @sudeeptarlekar