Merged
Conversation
Current Code Coverage Percent of this PR:88.64 %Files having coverage below 100%
|
| setLastName(name.join(" ")); | ||
| setIsUpdate(true); | ||
| } catch (error) { | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
We can replace console.error with this pattern.
Contributor
Author
There was a problem hiding this comment.
yeah will change it, but wondering what are we gonna do with the status?
| )); | ||
| setCurrencies(list); | ||
| } catch (error) { | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
We can replace console.error with this pattern.
ditto!
| const response = await profilesApi.get(); | ||
| setBillingDetails(response.data); | ||
| } catch (error) { | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
We can replace console.error with this pattern.
ditto!
| const fields = data.map(requirement => separateAddressFields(requirement)); | ||
| setBankRequirements(fields); | ||
| } catch (error) { | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
We can replace console.error with this pattern.
ditto!
apoorv1316
approved these changes
Jun 21, 2022
apoorv-mishra
approved these changes
Jun 23, 2022
Contributor
|
@sudeeptarlekar Please resolve the conflicts on this PR and merge it. |
Signed-off-by: sudeeptarlekar <[email protected]>
d2815dd to
ceda378
Compare
Contributor
Author
|
@supriya3105 rebased with develop |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
Signed-off-by: sudeeptarlekar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
NA
Summary
After failing wise api loading keeps spinning. Fixed the loader issue