Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix non billable filter value#504

Merged
supriya3105 merged 1 commit intodevelopfrom
fix-non-billable-filter
Jun 28, 2022
Merged

Fix non billable filter value#504
supriya3105 merged 1 commit intodevelopfrom
fix-non-billable-filter

Conversation

@shalapatil
Copy link
Contributor

@shalapatil shalapatil commented Jun 21, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/The-billing-status-filter-is-not-working-on-Timesheet-entry-report-819d384d69994a4fb78104ab4d8ae00f

Summary

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@shalapatil shalapatil requested a review from ajinkyaa June 21, 2022 06:23
@github-actions
Copy link

github-actions bot commented Jun 21, 2022

Current Code Coverage Percent of this PR:

89.28 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105 supriya3105 requested a review from apoorv1316 June 21, 2022 11:35
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 21, 2022

@apoorv1316 Please retest the bug

@apoorv1316
Copy link
Collaborator

apoorv1316 commented Jun 22, 2022

@shalapatil Supriya has a billed entry for the 25th of may but why it's not showing when I applied billed filter on reports

Screenshot 2022-06-22 at 10 28 43 AM

Screenshot 2022-06-22 at 10 29 00 AM

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 23, 2022

@shalapatil Can you please check review comments from apoorv Tiwari

@shalapatil
Copy link
Contributor Author

shalapatil commented Jun 24, 2022

I tested this and its working fine for me. Could you please check again?
Screenshot 2022-06-24 at 2 35 08 PM
Screenshot 2022-06-24 at 2 35 24 PM

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 27, 2022

@apoorv1316 Did you connect with Shalaka for this bug ?

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 28, 2022

@harshaanNihal Please review this PR .

@supriya3105 supriya3105 removed the request for review from ajinkyaa June 28, 2022 07:48
harshaanNihal
harshaanNihal approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@harshaanNihal harshaanNihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM ✨

@supriya3105 supriya3105 merged commit b6408c5 into develop Jun 28, 2022
@supriya3105 supriya3105 deleted the fix-non-billable-filter branch June 28, 2022 09:16
mohinid pushed a commit that referenced this pull request Jun 28, 2022
@shalapatil @mohinid
Fix non billable filter value (#504)
c2ccc82
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@shalapatil
Fix non billable filter value (#504)
f9094d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

1 more reviewer

@harshaanNihal harshaanNihal harshaanNihal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shalapatil @supriya3105 @apoorv1316 @harshaanNihal