Codestin Search App

gowsik-ragunath · 2022-06-21T06:28:14Z

Notion card

Summary

Removed the duplicate line item entries in the New line item dropdown and Add multiple line item modal.
Ordered record by work_date.

Preview

https://www.loom.com/share/cd22f158de294573991b963b03810c46

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to
not work as expected)
This change requires a documentation update

How Has This Been Tested?

Checklist:

I have manually tested all workflows
I have performed a self-review of my own code
I have added automated tests for my code

github-actions · 2022-06-21T06:30:20Z

Current Code Coverage Percent of this PR:

89.35 %

Files having coverage below 100%

Impacted Files	Coverage
/lib/custom_failure.rb	80.0 %
/app/controllers/users/invitations_controller.rb	86.36 %
/app/controllers/users/sessions_controller.rb	85.71 %
/app/services/invoice_payment/pdf_generation.rb	70.97 %
/app/services/invoice_payment/checkout.rb	44.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb	93.33 %
/app/controllers/internal_api/v1/profile_controller.rb	96.88 %
/app/controllers/internal_api/v1/companies_controller.rb	95.45 %
/app/controllers/internal_api/v1/payments/providers_controller.rb	94.74 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb	90.0 %
/lib/benchmarking/benchmarker.rb	0.0 %

akhilgkrishnan · 2022-06-21T06:30:16Z

app/models/client.rb

         timesheet_entries.note as description,
         project_members.hourly_rate as rate,
         timesheet_entries.duration as qty"
-      ).where.not(id: selected_entries)


@gowsik-ragunath can you add a test for this

Yeah @akhilgkrishnan - updated the existing test cases for this method.

akhilgkrishnan

LGTM

akhilgkrishnan · 2022-06-21T06:44:56Z

@mohinid can you check why the CI is failing. Cypress packages are not installing

mohinid · 2022-06-21T07:17:55Z

@mohinid can you check why the CI is failing. Cypress packages are not installing

@apoorv1316 Can you please check.

apoorv1316 · 2022-06-21T07:21:51Z

@gowsik-ragunath Why this PR is even installing cypress on CI I haven't merged the PR in which we are enabling the cypress test on CI. It's still open #490. cc @mohinid

gowsik-ragunath · 2022-06-21T07:31:34Z

@apoorv1316 I'm not sure, I didn't make any changes in the CI/CD workflow file.

The first commit did pass but the second commit failed because of the cypress installation issue I checked the workflow file in my local environment it didn't have anything related to cypress.

apoorv1316 · 2022-06-21T07:33:25Z

@gowsik-ragunath I am also not sure. Anway I re-run the job and all the checks seem fine now.

supriya3105 · 2022-06-21T11:36:20Z

@apoorv1316 Please retest this bug and approve/reject accordingly.

rohitjoshixyz

We should add an index on work date if we are sorting based on it cc @keshavbiswa

apoorv1316

Thanks a lot, @gowsik-ragunath for fixing this. cc @supriya3105

supriya3105 · 2022-06-22T06:34:20Z

@gowsik-ragunath Merging this. Added a new Notion card for @rohitjoshixyz 's feedback.

gowsik-ragunath · 2022-06-22T06:36:37Z

@supriya3105 Actually the change requested by @rohitjoshixyz was completed, I will raise a separate PR for that shortly.

* Fixed the issue in loading duplicate line items and ordering the results * Updated the new_line_item_entries model test case Co-authored-by: Gowsik <[email protected]>

Fixed the issue in loading duplicate line items and ordering the results

5678bea

gowsik-ragunath requested review from akhilgkrishnan, apoorv1316, rohitjoshixyz and supriya3105 June 21, 2022 06:28

pr-triage bot added the PR: unreviewed label Jun 21, 2022

akhilgkrishnan reviewed Jun 21, 2022

View reviewed changes

Updated the new_line_item_entries model test case

8c3f1b2

akhilgkrishnan approved these changes Jun 21, 2022

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels Jun 21, 2022

rohitjoshixyz reviewed Jun 21, 2022

View reviewed changes

apoorv1316 approved these changes Jun 22, 2022

View reviewed changes

supriya3105 merged commit bbcc8f5 into develop Jun 22, 2022

supriya3105 deleted the fixed-adding-multi-entries branch June 22, 2022 06:34

pr-triage bot added PR: merged and removed PR: partially-approved labels Jun 22, 2022

Conversation

gowsik-ragunath commented Jun 21, 2022

Notion card

Summary

Preview

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

github-actions bot commented Jun 21, 2022

Current Code Coverage Percent of this PR:

89.35 %

Files having coverage below 100%

Uh oh!

akhilgkrishnan Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

gowsik-ragunath Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

akhilgkrishnan left a comment

Choose a reason for hiding this comment

Uh oh!

akhilgkrishnan commented Jun 21, 2022

Uh oh!

mohinid commented Jun 21, 2022

Uh oh!

apoorv1316 commented Jun 21, 2022

Uh oh!

gowsik-ragunath commented Jun 21, 2022

Uh oh!

apoorv1316 commented Jun 21, 2022

Uh oh!

supriya3105 commented Jun 21, 2022

Uh oh!

rohitjoshixyz left a comment

Choose a reason for hiding this comment

Uh oh!

apoorv1316 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

supriya3105 commented Jun 22, 2022

Uh oh!

gowsik-ragunath commented Jun 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

apoorv1316 left a comment •

edited

Loading