Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use slice instead of fetch-values#510

Merged
supriya3105 merged 1 commit intodevelopfrom
fix-errors-on-report-page
Jun 22, 2022
Merged

Use slice instead of fetch-values#510
supriya3105 merged 1 commit intodevelopfrom
fix-errors-on-report-page

Conversation

@shalapatil
Copy link
Contributor

@shalapatil shalapatil commented Jun 22, 2022

Notion card

Summary

We are getting following error on prod.

KeyError key not found: "417"
path="/internal_api/v1/reports"
Parameters: {"group_by"=>"team_member"}

FetchValues raises exception if doesn't find any key. Used slice instead of it.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@shalapatil shalapatil requested a review from rohitjoshixyz June 22, 2022 03:10
@github-actions
Copy link

github-actions bot commented Jun 22, 2022

Current Code Coverage Percent of this PR:

89.35 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

rohitjoshixyz
rohitjoshixyz approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105 supriya3105 merged commit 5181320 into develop Jun 22, 2022
@supriya3105 supriya3105 deleted the fix-errors-on-report-page branch June 22, 2022 06:34
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@shalapatil
Use slice instead of fetch-values (#510)
6d92845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shalapatil @rohitjoshixyz @supriya3105