Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added index to work_date column#512

Merged
supriya3105 merged 2 commits intodevelopfrom
add-work-date-index
Jun 22, 2022
Merged

Added index to work_date column#512
supriya3105 merged 2 commits intodevelopfrom
add-work-date-index

Conversation

@gowsik-ragunath
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath commented Jun 22, 2022

Notion card

Summary

Added indexing to timesheet_entry's work_date column.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

rohitjoshixyz
rohitjoshixyz approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ref: concurrently

@github-actions
Copy link

github-actions bot commented Jun 22, 2022

Current Code Coverage Percent of this PR:

88.64 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105 supriya3105 merged commit 6f66508 into develop Jun 22, 2022
@supriya3105 supriya3105 deleted the add-work-date-index branch June 22, 2022 08:41
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@gowsik-ragunath
Added index to work_date column (#512)
0ad80ac 
Added index for timesheet entry work_date column

Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gowsik-ragunath @rohitjoshixyz @supriya3105