Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feedback changes for PR496#514

Merged
supriya3105 merged 1 commit intodevelopfrom
feedback-pr-496
Jun 22, 2022
Merged

Feedback changes for PR496#514
supriya3105 merged 1 commit intodevelopfrom
feedback-pr-496

Conversation

@harshaanNihal
Copy link
Contributor

@harshaanNihal harshaanNihal commented Jun 22, 2022

Notion card

https://www.notion.so/saeloun/Implement-Feedback-on-PR-https-github-com-saeloun-miru-web-pull-496-abaa22a9c2914642973a2a20c1a3b532

Summary

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@harshaanNihal harshaanNihal mentioned this pull request Jun 22, 2022
Merged
7 tasks
rohitjoshixyz
rohitjoshixyz approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 22, 2022

@harshaanNihal Please check the CI tests that are failing.

akhilgkrishnan
akhilgkrishnan reviewed Jun 22, 2022
View reviewed changes
app/jobs/weekly_reminder_to_user_job.rb
class WeeklyReminderToUserJob < ApplicationJob
def perform(*args)
if ENV["RAILS_LOG_TO_STDOUT"].present?
if ENV["ENABLE_WEEKLY_REMINDER"].present?
Copy link
Member

@akhilgkrishnan akhilgkrishnan Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the env to .env.example

Copy link
Contributor Author

@harshaanNihal harshaanNihal Jun 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already present in original PR without the value [by default OFF]
we can turn it ON by adding any string value to key

https://github.com/saeloun/miru-web/pull/496/files#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8cR47

@github-actions
Copy link

github-actions bot commented Jun 22, 2022

Current Code Coverage Percent of this PR:

88.64 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

akhilgkrishnan
akhilgkrishnan approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105 supriya3105 merged commit 890d332 into develop Jun 22, 2022
@supriya3105 supriya3105 deleted the feedback-pr-496 branch June 22, 2022 14:11
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@harshaanNihal
Feedback changes for PR496 (#514)
de30d58 
add feedback changes for PR 496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

+1 more reviewer

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshaanNihal @supriya3105 @akhilgkrishnan @rohitjoshixyz