Update 'company_users' table with employment details#515
Merged
Conversation
rohitjoshixyz
approved these changes
Jun 23, 2022
Contributor
rohitjoshixyz
left a comment
There was a problem hiding this comment.
LGTM 🎉 Let's decide on whether to use date or datetime. I have not explored it
Contributor
Author
|
@rohitjoshixyz @keshavbiswa @akhilgkrishnan - I am working on creating separate PR for changes to add instances of company_users in the repo including seed data. |
This reverts commit f4e6141.
keshavbiswa
reviewed
Jun 24, 2022
Contributor
keshavbiswa
left a comment
There was a problem hiding this comment.
Added few suggestions, rest LGTM
Co-authored-by: Keshav Biswa <[email protected]>
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Remove association between employment_details and company_users * Update company_users table with employment details * Drop table 'employment_details' * Changes - Renamed table company_users as employments - Updated Model file name and replaced company_user instances with employment - Updated reference name in User and Company model - Updated RSpecs- Employment, User and Company * Revert "Changes" This reverts commit f4e6141. * Remove 'address' changes from schema * Update spec/models/company_user_spec.rb Co-authored-by: Keshav Biswa <[email protected]> Co-authored-by: Keshav Biswa <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Add-tables-for-personal-employment-Allocated-devices-Address-71ef49d0c38e4242bd2998120141372d
Summary
Preview
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested manually and with RSpecs on local.
Checklist: