Refactor route to consider report type#516
Merged
supriya3105 merged 3 commits intodevelopfrom Jun 27, 2022
Merged
Conversation
Current Code Coverage Percent of this PR:88.64 %Files having coverage below 100%
|
Contributor
rohitjoshixyz
left a comment
There was a problem hiding this comment.
A couple of suggestions
| # frozen_string_literal: true | ||
|
|
||
| module Report | ||
| module TimeEntryReport |
Contributor
There was a problem hiding this comment.
Just a suggestion and you can take the call if you want to change it or not. I would prefer to keep the service namespaces consistent with the controller namespacing in which they are being used.
i.e: app/controllers/reports/time_entry_controller could have its services defined in app/services/reports/time_entry/result_service.rb and so on
| end | ||
|
|
||
| it "is not permitted to view time entry report" do | ||
| it "is not permitted to view cliet details" do |
Contributor
There was a problem hiding this comment.
Typo
Suggested change
| it "is not permitted to view cliet details" do | |
| it "is not permitted to view client details" do |
| # frozen_string_literal: true | ||
|
|
||
| class InternalApi::V1::ReportsController < InternalApi::V1::ApplicationController | ||
| class InternalApi::V1::Reports::TimeEntryController < InternalApi::V1::ApplicationController |
Contributor
There was a problem hiding this comment.
As per rails conventions, we should name the controller in plural form. TimeEntriesController
rohitjoshixyz
approved these changes
Jun 24, 2022
Contributor
rohitjoshixyz
left a comment
There was a problem hiding this comment.
Thank you for working on the refactoring. LGTM 🎉
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Refactor route to consider report type * Fix spec path * Fix suggested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
Summary
For reports page, we will have multiple types of reports. So, now api routes will look like "......./reports/time_entry" instead of "....../reports"
Did refactoring for other related code also
Preview
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: