Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed the issue in assigning role to team member#518

Merged
supriya3105 merged 1 commit intodevelopfrom
fix-team-role-issue
Jun 28, 2022
Merged

Fixed the issue in assigning role to team member#518
supriya3105 merged 1 commit intodevelopfrom
fix-team-role-issue

Conversation

@gowsik-ragunath
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath commented Jun 23, 2022

Slack message link

https://saelounus.slack.com/archives/C03GHMCAMST/p1655970158725439

Summary

Fixed the issue in update team action when the role is not passed in params.

To reproduce this issue,

  • In Edit team member form uncheck any selected roles (can be done by updating the HTML in inspect)
  • Submit the form and it will show an error flash message.

Preview

Screenshot 2022-06-23 at 5 00 03 PM

Screenshot 2022-06-23 at 5 00 11 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

abinashpa
abinashpa reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@abinashpa abinashpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105 supriya3105 requested a review from apoorv1316 June 24, 2022 06:29
@supriya3105
Copy link
Contributor

supriya3105 commented Jun 24, 2022

@apoorv1316 Please check the sign up and add team members functionality for this PR.

@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

88.65 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 27, 2022

@apoorv1316 Please test the add team member functionality for this PR.

@supriya3105
Copy link
Contributor

supriya3105 commented Jun 28, 2022

@rohitjoshixyz Please review this PR.

rohitjoshixyz
rohitjoshixyz approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105 supriya3105 merged commit 2fe91d2 into develop Jun 28, 2022
@supriya3105 supriya3105 deleted the fix-team-role-issue branch June 28, 2022 08:31
mohinid pushed a commit that referenced this pull request Jun 28, 2022
@gowsik-ragunath @mohinid
Fixed the issue in assigning role to team member (#518)
59b334e 
Fixed the issue in setting role when role is not passed

Co-authored-by: Gowsik <[email protected]>
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@gowsik-ragunath
Fixed the issue in assigning role to team member (#518)
b8d4733 
Fixed the issue in setting role when role is not passed

Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

2 more reviewers

@abinashpa abinashpa abinashpa left review comments

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gowsik-ragunath @supriya3105 @rohitjoshixyz @abinashpa