disable payment nav section and banking details#521
Merged
akhilgkrishnan merged 6 commits intodevelopfrom Jun 27, 2022
Merged
Conversation
1e107ce to
6115fe1
Compare
Current Code Coverage Percent of this PR:88.65 %Files having coverage below 100%
|
gowsik-ragunath
approved these changes
Jun 24, 2022
| it { is_expected.to validate_presence_of(:joined_at) } | ||
| it { is_expected.to validate_presence_of(:employee_id) } | ||
| end | ||
| # describe "Validations" do |
Member
There was a problem hiding this comment.
@harshaanNihal revert this change. Mohini is working on this
Contributor
Author
There was a problem hiding this comment.
We can revert back the changes once when the front end/seed data have required changes related to the company_user validation.
| # Validations | ||
| validates :designation, :employment_type, :joined_at, :employee_id, presence: true | ||
| validates :resigned_at, comparison: { greater_than: :joined_at }, unless: -> { resigned_at.nil? } | ||
| # validates :designation, :employment_type, :joined_at, :employee_id, presence: true |
Member
There was a problem hiding this comment.
revert this change. Mohini is working on this
1c76a16 to
e4254cc
Compare
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* disable payment navtab * Commented company user related validation * Removed test cases for company users validation * revert policy and comment out links directly * comment out embedded ruby explicitely inside comments Co-authored-by: Gowsik <[email protected]> Co-authored-by: Akhil G Krishnan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
Summary
BEFORE
AFTER
Preview
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: