Refactor: Added Navigation Helper to generate navbar items dynamically#524
Merged
supriya3105 merged 4 commits intodevelopfrom Jun 28, 2022
Merged
Refactor: Added Navigation Helper to generate navbar items dynamically#524supriya3105 merged 4 commits intodevelopfrom
supriya3105 merged 4 commits intodevelopfrom
Conversation
Current Code Coverage Percent of this PR:88.79 %Files having coverage below 100%
|
Contributor
|
@keshavbiswa Please check the review comments. |
Contributor
Author
|
@rohitjoshixyz @supriya3105 Addressed the code review concerns. Thanks for the catch @rohitjoshixyz |
rohitjoshixyz
approved these changes
Jun 28, 2022
Contributor
|
@keshavbiswa The CI checks are failing on this PR. Please check |
Contributor
Author
Fixed all failing tests @supriya3105 |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
#524) * Added Navigation Helper * code review changes * fixed failng tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
Summary
We were using a lot of static anchor tags to generate our navbar items which were quite redundant.
Preview
Type of change
Added Navigation Helper
Rendered Navbars using
nav_helperPlease delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to
not work as expected)
This change requires a documentation update
How Has This Been Tested?
Checklist: