Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed the issue in opening edit project modal on client detail page#525

Merged
supriya3105 merged 3 commits intodevelopfrom
fix-edit-project
Jun 28, 2022
Merged

Fixed the issue in opening edit project modal on client detail page#525
supriya3105 merged 3 commits intodevelopfrom
fix-edit-project

Conversation

@gowsik-ragunath
Copy link
Contributor

Notion card

https://www.notion.so/saeloun/Edit-project-not-working-on-client-id-page-1bccdaa4950f414d9258458cfcd6f3d5

Summary

Fixed the issue in opening the edit project modal on the client detail page.

Preview

Screenshot 2022-06-24 at 7 06 06 PM

Screenshot 2022-06-24 at 7 06 13 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@gowsik-ragunath gowsik-ragunath requested review from abinashpa, ajinkyaa, apoorv1316 and supriya3105 and removed request for abinashpa June 24, 2022 13:37
@supriya3105
Copy link
Contributor

@gowsik-ragunath Please The check the CI tests that are failing on this PR.

@github-actions
Copy link

Current Code Coverage Percent of this PR:

88.65 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.97 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@gowsik-ragunath
Copy link
Contributor Author

@supriya3105 Fixed the failing test cases CI is passing now.

Copy link
Contributor

@abinashpa abinashpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@supriya3105 supriya3105 merged commit 4452b09 into develop Jun 28, 2022
@supriya3105 supriya3105 deleted the fix-edit-project branch June 28, 2022 07:49
mohinid pushed a commit that referenced this pull request Jun 28, 2022
…525)

* Fixed the issue in opening edit project modal in client detail page

* Fixed the failing test cases

Co-authored-by: Gowsik <[email protected]>
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
…525)

* Fixed the issue in opening edit project modal in client detail page

* Fixed the failing test cases

Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants