Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename company_users as employments#526

Merged
mohinid merged 11 commits intodevelopfrom
rename-company_users-to-employment
Jul 1, 2022
Merged

Rename company_users as employments#526
mohinid merged 11 commits intodevelopfrom
rename-company_users-to-employment

Conversation

@mohinid
Copy link
Contributor

@mohinid mohinid commented Jun 27, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Add-tables-for-personal-employment-Allocated-devices-Address-71ef49d0c38e4242bd2998120141372d

Summary

  1. Rename company_users table as employments.
  2. Update RSpecs for new Model Name.
  3. Update all instances of CompanyUsers, company_users, and company_user in the repo.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

On local Rails console and RSpecs.

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@mohinid mohinid requested a review from akhilgkrishnan June 27, 2022 07:58
@mohinid mohinid self-assigned this Jun 27, 2022
@mohinid
Copy link
Contributor Author

mohinid commented Jun 27, 2022

@akhilgkrishnan can you pls help me with resolving conflicts and failing tests.

@akhilgkrishnan akhilgkrishnan force-pushed the rename-company_users-to-employment branch from b29665a to f8eeace Compare June 27, 2022 08:04
keshavbiswa
keshavbiswa reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@keshavbiswa keshavbiswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions added.

akhilgkrishnan
akhilgkrishnan reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohinid can you test the entire miru flow in the branch

@akhilgkrishnan akhilgkrishnan mentioned this pull request Jun 28, 2022
Merged
7 tasks
@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

89.13 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 92.86 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@mohinid
Copy link
Contributor Author

mohinid commented Jun 28, 2022

Current RSpec status on this branch- 745 examples, 0 failures, 4 pending

@mohinid
Copy link
Contributor Author

mohinid commented Jun 28, 2022

@akhilgkrishnan Will create separate PR for adding seed files for new tables.

@mohinid mohinid requested a review from apoorv-mishra June 28, 2022 12:19
@supriya3105 supriya3105 removed the request for review from apoorv-mishra June 29, 2022 07:39
keshavbiswa
keshavbiswa reviewed Jun 30, 2022
View reviewed changes
mohinid added 9 commits June 30, 2022 19:51
@mohinid
Changes
b8c02ec 
- Update company_users table name to employment
- Update all instances of company_users to employments
@mohinid
fix employment specs
620570d
@mohinid
Comment out all tests for Wise
7c5cb97
@mohinid
Add TODO comment to Wise tests
8287c37
@mohinid
Add TODO to Wise services tests
83b21c9
@mohinid
Commented out Employment Validations
a370223
@mohinid
Fix failing tests
55c6614
@mohinid
Changes
8dcbda0 
- Update company_users table name to employment
- Update all instances of company_users to employments
@mohinid
Fix company_user instances in new specs
7acd195
@mohinid mohinid force-pushed the rename-company_users-to-employment branch from beeeafb to 7acd195 Compare June 30, 2022 14:22
keshavbiswa
keshavbiswa approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@keshavbiswa keshavbiswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supriya3105
Copy link
Contributor

supriya3105 commented Jul 1, 2022

@rohitjoshixyz Please review this PR and approve if all inline with the ERD.

rohitjoshixyz
rohitjoshixyz approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check for wise specs, if they pass uncomment them else go ahead and merge! 🎉

@mohinid
Copy link
Contributor Author

mohinid commented Jul 1, 2022

LGTM, check for wise specs, if they pass uncomment them else go ahead and merge! 🎉

Passing on local. Uncommented Wise tests. Lets see on CI

Finished in 2 minutes 25.5 seconds (files took 4.15 seconds to load)
794 examples, 0 failures, 4 pending

@mohinid
Copy link
Contributor Author

mohinid commented Jul 1, 2022

@rohitjoshixyz @keshavbiswa Wise tests passing too! Merging the PR :)

@mohinid mohinid merged commit c1191ff into develop Jul 1, 2022
@mohinid mohinid deleted the rename-company_users-to-employment branch July 1, 2022 05:39
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Rename company_users as employments (#526)
195b3cc 
* Changes
- Update company_users table name to employment
- Update all instances of company_users to employments

* fix employment specs

* Comment out all tests for Wise

* Add TODO comment to Wise tests

* Add TODO to Wise services tests

* Commented out Employment Validations

* Fix failing tests

* Changes
- Update company_users table name to employment
- Update all instances of company_users to employments

* Fix company_user instances in new specs

* fix update_spec.rb

* Uncomment Wise tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan left review comments

@keshavbiswa keshavbiswa keshavbiswa approved these changes

+1 more reviewer

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mohinid mohinid

Labels

feature PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mohinid @supriya3105 @akhilgkrishnan @rohitjoshixyz @keshavbiswa