Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Client revenue report#527

Merged
supriya3105 merged 14 commits intodevelopfrom
client-revenue-report
Jun 28, 2022
Merged

Client revenue report#527
supriya3105 merged 14 commits intodevelopfrom
client-revenue-report

Conversation

@shalapatil
Copy link
Contributor

@shalapatil shalapatil commented Jun 27, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Create-the-API-s-to-fetch-the-data-for-revenue-by-clients-Reports-a1fd73538faa466f8442ce75ec89cb25

Summary

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

rohitjoshixyz
rohitjoshixyz approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

db/schema.rb
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema[7.0].define(version: 2022_06_22_160123) do

Copy link
Contributor

@rohitjoshixyz rohitjoshixyz Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this change

@shalapatil shalapatil force-pushed the client-revenue-report branch from 052e9cf to 0f887bc Compare June 28, 2022 06:15
@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Current Code Coverage Percent of this PR:

88.82 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@supriya3105 supriya3105 merged commit 04e3f71 into develop Jun 28, 2022
@supriya3105 supriya3105 deleted the client-revenue-report branch June 28, 2022 12:42
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@shalapatil
Client revenue report (#527)
d43a102 
* Refactor route to consider report type

* Fix spec path

* Add API for client revenue report

* Fix suggested changes

* Fix controller name

* Add specs for all roles other than admins

* Update schema.rb

* fix flaky test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv-mishra apoorv-mishra Awaiting requested review from apoorv-mishra

1 more reviewer

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shalapatil @rohitjoshixyz @supriya3105