Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added social media link and currency symbol to amount#528

Merged
gowsik-ragunath merged 4 commits intodevelopfrom
fixed-invoice-email
Jun 28, 2022
Merged

Added social media link and currency symbol to amount#528
gowsik-ragunath merged 4 commits intodevelopfrom
fixed-invoice-email

Conversation

@gowsik-ragunath
Copy link
Contributor

Notion card

https://www.notion.so/saeloun/Remaining-work-on-Invoice-email-d858e7409f1542e3b6f3fee9799520dc

Summary

  • Added a service that returns amount with currency symbol.
  • Added social media link in mail footer.

Preview

https://www.loom.com/share/689375139f4f4a2c922fb7e025a12831

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

Current Code Coverage Percent of this PR:

88.71 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gowsik-ragunath gowsik-ragunath merged commit 0701688 into develop Jun 28, 2022
@gowsik-ragunath gowsik-ragunath deleted the fixed-invoice-email branch June 28, 2022 07:14
mohinid pushed a commit that referenced this pull request Jun 28, 2022
* Amount in invoice mail will be displayed with currency symbol and added social media link at footer

* Added test cases for format amount service

* Removed unwanted style from social media icons

* Fixed the failed test cases and updated the service to return string amount

Co-authored-by: Gowsik <[email protected]>
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
* Amount in invoice mail will be displayed with currency symbol and added social media link at footer

* Added test cases for format amount service

* Removed unwanted style from social media icons

* Fixed the failed test cases and updated the service to return string amount

Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants