Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Amount in project detail page will have company default currency symbol#529

Merged
supriya3105 merged 6 commits intodevelopfrom
team-member-currency-bug
Jun 28, 2022
Merged

Amount in project detail page will have company default currency symbol#529
supriya3105 merged 6 commits intodevelopfrom
team-member-currency-bug

Conversation

@gowsik-ragunath
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath commented Jun 28, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Team-member-hourly-rate-currency-bug-080f697e4cef4cab9bbd0f10add3570b

Summary

On the project detail page, the amount displayed against each team member will have the company's default currency symbol before it.

Preview

Screenshot 2022-06-28 at 12 18 54 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@pr-triage pr-triage bot added the PR: draft label Jun 28, 2022
@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

88.74 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 86.36 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@gowsik-ragunath gowsik-ragunath marked this pull request as ready for review June 28, 2022 07:25
rohitjoshixyz
rohitjoshixyz reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why don't we use the FormatAmountService here as it is merged now?

@gowsik-ragunath
Copy link
Contributor Author

gowsik-ragunath commented Jun 28, 2022

Yeah @rohitjoshixyz , we can use the FormatAmountService here instead of formatting amount in the frontend, will update it shortly.

@gowsik-ragunath
Copy link
Contributor Author

gowsik-ragunath commented Jun 28, 2022

@rohitjoshixyz updated the code, now we are using the service to get the formatted amount.

rohitjoshixyz
rohitjoshixyz approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105 supriya3105 merged commit 3488e32 into develop Jun 28, 2022
@supriya3105 supriya3105 deleted the team-member-currency-bug branch June 28, 2022 13:22
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@gowsik-ragunath
Amount in project detail page will have company default currency symb…
e315bdb 
…ol (#529)

* Added correct currency symbol to project index page

* Updated project model specs

* Fixed inundation issue

* Used FormatAmountService to format the project related amount values

* Reused format method in project model in test cases

Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

@supriya3105 supriya3105 Awaiting requested review from supriya3105

@ajinkyaa ajinkyaa Awaiting requested review from ajinkyaa

1 more reviewer

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gowsik-ragunath @rohitjoshixyz @supriya3105