Conversation
…port-list-page merging develop branch
Current Code Coverage Percent of this PR:88.92 %Files having coverage below 100%
|
onkar-saeloun
commented
Jun 28, 2022
| @@ -1,126 +1,18 @@ | |||
| import React, { useState, useEffect } from "react"; | |||
Contributor
Author
There was a problem hiding this comment.
removed this file, added a separate time entry report file and added routing in same file.
Member
akhilgkrishnan
left a comment
There was a problem hiding this comment.
@onkar-saeloun can we hide the rest of the empty reports
Contributor
Author
Ohh like for now we will show only Time entry report on list? |
Contributor
|
@onkar-saeloun . Please hide the rest of the reports for now. |
Contributor
|
@akhilgkrishnan Please review this PR again for feedback that has been implemented |
Comment on lines
37
to
38
| setAuthHeaders(); | ||
| registerIntercepts(); |
Member
There was a problem hiding this comment.
move these to app/javascript/src/components/Reports/index.tsx
Contributor
|
@onkar-saeloun Please resolve the conflicts on this PR also 1 feedback from Akhil |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* added width and height properties in tailwind config * added reports routes * added route conf * added reports header * added outstanding amt page * added report card component * added report card * added revenue by client page * added time entry page * added total hours logged page * added routes path for reports * added svgs for report list page * added route in navbar * added flag to show the report in list * resolved comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Create-the-Reports-List-page-b36ccfd750af40f39864b342cdbc2ca9
Summary
Created a page to show list of projects.
Preview
Miru._.Time.tracking.and.invoicing.-.28.June.2022.1.mp4
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested Manually
Checklist: