Revenue by clients report page UI and common context for all reports.#537
Merged
supriya3105 merged 45 commits intodevelopfrom Jul 5, 2022
Merged
Revenue by clients report page UI and common context for all reports.#537supriya3105 merged 45 commits intodevelopfrom
supriya3105 merged 45 commits intodevelopfrom
Conversation
…port-list-page merging develop branch
…port-list-page merging develop
Collaborator
|
@onkar-saeloun Clear all button is not removing the "this quarter" filter. Please check. |
apoorv1316
approved these changes
Jul 4, 2022
Contributor
|
@harshaanNihal $ @akhilgkrishnan Please view this PR and provide your comments. |
harshaanNihal
approved these changes
Jul 4, 2022
| const years = range(1990, getYear(new Date()) + 1); | ||
| const months = [ | ||
| "Jan", | ||
| "Febr", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Febr", | |
| "Feb", |
| wrapperClassName="datePicker absolute" | ||
| inline | ||
| calendarClassName="miru-calendar-date-range" | ||
| minDate={(selectedInput === "to-input" && dateRange.from) ? new Date(dateRange.from) : null} |
Contributor
There was a problem hiding this comment.
can we move "to-input", "from-input" to constants variable.
Comment on lines
+28
to
+37
| const getReport = (currentReport) => { | ||
| switch (currentReport) { | ||
| case "RevenueByClientReport": | ||
| return revenueByClientReport; | ||
| case "TimeEntryReport": | ||
| return timeEntryReport; | ||
| default: | ||
| break; | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
DRY the function. we are defining the same function in
app/javascript/src/components/Reports/Header/NavigationFilter.tsx:7 aswell
Contributor
Author
There was a problem hiding this comment.
@harshaanNihal This refactoring is already done in API integration branch will raise separate PR for this.
JijoBose
reviewed
Jul 4, 2022
Current Code Coverage Percent of this PR:89.13 %Files having coverage below 100%
|
JijoBose
approved these changes
Jul 5, 2022
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
…#537) * added width and height properties in tailwind config * added reports routes * added route conf * added reports header * added outstanding amt page * added report card component * added report card * added revenue by client page * added time entry page * added total hours logged page * added routes path for reports * added svgs for report list page * added route in navbar * added flag to show the report in list * resolved comment * added total header page * changed time enty import * changed entry context * added z index * added revenue by client context * added time entry context * added time entry context import * added time entry context * added navigation changes * added revenue by client page * added header * added table * added filter * added styles * added time entry context * added changes in date util * added css * added filter * added custom date rage * added filter counter * added filte rrelated changes * added interface * added css changes * added css changes * resolved comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Create-the-front-end-for-revenue-by-clients-reports-b170ac9a1b2c44d1961fed9393a05a82
Summary
Preview
Miru._.Time.tracking.and.invoicing.-.1.July.2022.mp4
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested Manually on my local machine.
Checklist: