Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Invoice search#538

Merged
supriya3105 merged 8 commits intodevelopfrom
feature/invoice-search
Jul 5, 2022
Merged

Invoice search#538
supriya3105 merged 8 commits intodevelopfrom
feature/invoice-search

Conversation

@harshaanNihal
Copy link
Contributor

@harshaanNihal harshaanNihal commented Jul 1, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Implement-Search-on-Invoice-List-page-1531f9fb8ac94c62b04485c316c081c7

Summary

  • Added a Invoice search functionality.
  • Added a debounce for search queries for 500ms.
  • currently the max number of search result displayed is set to 5.

Preview

https://www.loom.com/share/ad6a8c26dd3d42bfb08d4d6c6dd89b39

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@pr-triage pr-triage bot added the PR: draft label Jul 1, 2022
@harshaanNihal harshaanNihal marked this pull request as ready for review July 4, 2022 06:08
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Current Code Coverage Percent of this PR:

89.14 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 92.86 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@apoorv1316 apoorv1316 self-requested a review July 4, 2022 08:02
apoorv1316
apoorv1316 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harshaanNihal harshaanNihal changed the title Feature/invoice search Invoice search Jul 4, 2022
@harshaanNihal harshaanNihal force-pushed the feature/invoice-search branch from d7ad25f to 9f094e8 Compare July 4, 2022 22:32
gowsik-ragunath
gowsik-ragunath approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supriya3105 supriya3105 merged commit 3313906 into develop Jul 5, 2022
@supriya3105 supriya3105 deleted the feature/invoice-search branch July 5, 2022 07:33
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@harshaanNihal
Invoice search (#538)
8f9fed7 
* Bind the search input Two-way

* Setup Invoice search with the given search query

* Add debounce for search query

* fix clearSearch functionality and code refactor

* Add search specs

* Revert Table search and add dropdown list

* center no result text

* Add full search on enter key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@gowsik-ragunath gowsik-ragunath gowsik-ragunath approved these changes

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshaanNihal @apoorv1316 @gowsik-ragunath @supriya3105